Changeset 34492 for trunk/tests/phpunit/tests/canonical.php

Timestamp:

09/24/2015 02:03:05 PM (9 years ago)

Author:

wonderboymusic

Message:

Canonical/Rewrite: sanity check posts that are paged with <!--nextpage-->. Page numbers past the max number of pages are returning the last page of content and causing infinite duplicate content.

Awesome rewrite bug: the page query var was being set to '/4' in $wp. When cast to int, it returns 0 (Bless you, PHP). WP_Query calls trim( $page, '/' ) when setting its own query var. The few places that were checking page before posts were queried now have sanity checks, so that these changes work without flushing rewrites.

Adds/updates unit tests.

Props wonderboymusic, dd32.
See #11694.

File:

• trunk/tests/phpunit/tests/canonical.php (modified) (1 diff)

trunk/tests/phpunit/tests/canonical.php

@@ -97 +97 @@
             array( '/post-format-test-au/', '/2008/06/02/post-format-test-audio/'),
 
-            array( '/2008/09/03/images-test/3/', array( 'url' => '/2008/09/03/images-test/3/', 'qv' => array( 'name' => 'images-test', 'year' => '2008', 'monthnum' => '09', 'day' => '03', 'page' => '/3' ) ) ), // page = /3 ?!
+            array( '/2008/09/03/images-test/3/', array( 'url' => '/2008/09/03/images-test/3/', 'qv' => array( 'name' => 'images-test', 'year' => '2008', 'monthnum' => '09', 'day' => '03', 'page' => '3' ) ) ),
             array( '/2008/09/03/images-test/?page=3', '/2008/09/03/images-test/3/' ),
             array( '/2008/09/03/images-te?page=3', '/2008/09/03/images-test/3/' ),