Changeset 34535 for trunk/tests/phpunit/tests/comment/getPageOfComment.php

Timestamp:

09/25/2015 05:10:40 AM (10 years ago)

Author:

boonebgorges

Message:

Use WP_Comment_Query in get_page_of_comment().

This change allows get_page_of_comment() to use WP_Comment_Query's native
caching mechanisms.

Props boonebgorges, Viper007Bond, wmertens, jeremyfelt.
Fixes #11334.

File:

• trunk/tests/phpunit/tests/comment/getPageOfComment.php (modified) (2 diffs)

trunk/tests/phpunit/tests/comment/getPageOfComment.php

@@ -6 +6 @@
  */
 class Tests_Comment_GetPageOfComment extends WP_UnitTestCase {
-
-    public function setUp() {
-        parent::setUp();
-    }
 
     public function test_last_comment() {
@@ -39 +35 @@
         $this->assertEquals( 1, get_page_of_comment( $comment_first[0], array( 'per_page' => 10 ) ) );
     }
+
+    public function test_type_pings() {
+        $p = $this->factory->post->create();
+        $now = time();
+
+        $trackbacks = array();
+        for ( $i = 0; $i <= 3; $i++ ) {
+            $trackbacks[ $i ] = $this->factory->comment->create( array( 'comment_post_ID' => $p, 'comment_type' => 'trackback', 'comment_date_gmt' => date( 'Y-m-d H:i:s', $now ) ) );
+            $now -= 10 * $i;
+        }
+
+        $pingbacks = array();
+        for ( $i = 0; $i <= 6; $i++ ) {
+            $pingbacks[ $i ] = $this->factory->comment->create( array( 'comment_post_ID' => $p, 'comment_type' => 'pingback', 'comment_date_gmt' => date( 'Y-m-d H:i:s', $now ) ) );
+            $now -= 10 * $i;
+        }
+
+        $this->assertEquals( 2, get_page_of_comment( $trackbacks[0], array( 'per_page' => 2, 'type' => 'trackback' ) ) );
+        $this->assertEquals( 3, get_page_of_comment( $pingbacks[0], array( 'per_page' => 2, 'type' => 'pingback' ) ) );
+        $this->assertEquals( 5, get_page_of_comment( $trackbacks[0], array( 'per_page' => 2, 'type' => 'pings' ) ) );
+    }
+
+    /**
+     * @ticket 11334
+     */
+    public function test_subsequent_calls_should_hit_cache() {
+        global $wpdb;
+
+        $p = $this->factory->post->create();
+        $c = $this->factory->comment->create( array( 'comment_post_ID' => $p ) );
+
+        // Prime cache.
+        $page_1 = get_page_of_comment( $c, array( 'per_page' => 3 ) );
+
+        $num_queries = $wpdb->num_queries;
+        $page_2 = get_page_of_comment( $c, array( 'per_page' => 3 ) );
+
+        $this->assertSame( $page_1, $page_2 );
+        $this->assertSame( $num_queries, $wpdb->num_queries );
+    }
+
+    /**
+     * @ticket 11334
+     */
+    public function test_cache_hits_should_be_sensitive_to_comment_type() {
+        global $wpdb;
+
+        $p = $this->factory->post->create();
+        $comment = $this->factory->comment->create( array( 'comment_post_ID' => $p, 'comment_type' => 'comment' ) );
+
+        $now = time();
+        $trackbacks = array();
+        for ( $i = 0; $i <= 5; $i++ ) {
+            $trackbacks[ $i ] = $this->factory->comment->create( array( 'comment_post_ID' => $p, 'comment_type' => 'trackback', 'comment_date_gmt' => date( 'Y-m-d H:i:s', $now - ( 10 * $i ) ) ) );
+        }
+
+        // Prime cache for trackbacks.
+        $page_trackbacks = get_page_of_comment( $trackbacks[1], array( 'per_page' => 3, 'type' => 'trackback' ) );
+        $this->assertEquals( 2, $page_trackbacks );
+
+        $num_queries = $wpdb->num_queries;
+        $page_comments = get_page_of_comment( $comment, array( 'per_page' => 3, 'type' => 'comment' ) );
+        $this->assertEquals( 1, $page_comments );
+
+        $this->assertNotEquals( $num_queries, $wpdb->num_queries );
+    }
+
+    /**
+     * @ticket 11334
+     */
+    public function test_cache_should_be_invalidated_when_comment_is_approved() {
+        $p = $this->factory->post->create();
+        $c = $this->factory->comment->create( array( 'comment_post_ID' => $p, 'comment_approved' => 0 ) );
+
+        // Prime cache.
+        $page_1 = get_page_of_comment( $c, array( 'per_page' => 3 ) );
+
+        // Approve comment.
+        wp_set_comment_status( $c, 'approve' );
+
+        $this->assertFalse( wp_cache_get( $c, 'comment_pages' ) );
+    }
+
+    /**
+     * @ticket 11334
+     */
+    public function test_cache_should_be_invalidated_when_comment_is_deleted() {
+        $p = $this->factory->post->create();
+        $c = $this->factory->comment->create( array( 'comment_post_ID' => $p ) );
+
+        // Prime cache.
+        $page_1 = get_page_of_comment( $c, array( 'per_page' => 3 ) );
+
+        // Trash comment.
+        wp_trash_comment( $c );
+
+        $this->assertFalse( wp_cache_get( $c, 'comment_pages' ) );
+    }
+
+    /**
+     * @ticket 11334
+     */
+    public function test_cache_should_be_invalidated_when_comment_is_spammed() {
+        $p = $this->factory->post->create();
+        $c = $this->factory->comment->create( array( 'comment_post_ID' => $p ) );
+
+        // Prime cache.
+        $page_1 = get_page_of_comment( $c, array( 'per_page' => 3 ) );
+
+        // Spam comment.
+        wp_spam_comment( $c );
+
+        $this->assertFalse( wp_cache_get( $c, 'comment_pages' ) );
+    }
+
+    /**
+     * @ticket 11334
+     */
+    public function test_cache_should_be_invalidated_when_older_comment_is_published() {
+        $now = time();
+
+        $p = $this->factory->post->create();
+        $c1 = $this->factory->comment->create( array( 'comment_post_ID' => $p, 'comment_date_gmt' => date( 'Y-m-d H:i:s', $now ) ) );
+        $c2 = $this->factory->comment->create( array( 'comment_post_ID' => $p, 'comment_date_gmt' => date( 'Y-m-d H:i:s', $now - 20 ) ) );
+        $c3 = $this->factory->comment->create( array( 'comment_post_ID' => $p, 'comment_approved' => 0, 'comment_date_gmt' => date( 'Y-m-d H:i:s', $now - 30 ) ) );
+
+        $this->assertEquals( 1, get_page_of_comment( $c1, array( 'per_page' => 2 ) ) );
+
+        wp_set_comment_status( $c3, '1' );
+
+        $this->assertEquals( 2, get_page_of_comment( $c1, array( 'per_page' => 2 ) ) );
+    }
 }