Changeset 34544 for trunk/tests/phpunit/tests/comment/query.php

Timestamp:

09/25/2015 02:34:20 PM (10 years ago)

Author:

boonebgorges

Message:

Improve pagination internals in WP_Comment_Query.

WP_Comment_Query will now report the total number of comments matching the
query params (comments_found), as well as the total number of pages required
to display these comments (max_num_pages). Because SQL_CALC_FOUND_ROWS
queries can introduce a lot of overhead in some cases, we disable the feature
by default. Pass no_found_rows=false to WP_Comment_Query to enable the
count. (We use the negative parameter name 'no_found_rows' for parity with
WP_Query.)

Props wonderboymusic, boonebgorges.
See #8071.

File:

• trunk/tests/phpunit/tests/comment/query.php (modified) (1 diff)

trunk/tests/phpunit/tests/comment/query.php

@@ -1874 +1874 @@
 
     }
+
+    /**
+     * @ticket 8071
+     */
+    public function test_no_found_rows_should_default_to_true() {
+        $comments = $this->factory->comment->create_many( 3, array( 'comment_post_ID' => $this->post_id ) );
+
+        $q = new WP_Comment_Query( array(
+            'post_id' => $this->post_id,
+            'number' => 2,
+        ) );
+
+        $this->assertEquals( 0, $q->found_comments );
+        $this->assertEquals( 0, $q->max_num_pages );
+    }
+
+    /**
+     * @ticket 8071
+     */
+    public function test_should_respect_no_found_rows_true() {
+        $comments = $this->factory->comment->create_many( 3, array( 'comment_post_ID' => $this->post_id ) );
+
+        $q = new WP_Comment_Query( array(
+            'post_id' => $this->post_id,
+            'number' => 2,
+            'no_found_rows' => true,
+        ) );
+
+        $this->assertEquals( 0, $q->found_comments );
+        $this->assertEquals( 0, $q->max_num_pages );
+    }
+
+    /**
+     * @ticket 8071
+     */
+    public function test_should_respect_no_found_rows_false() {
+        $comments = $this->factory->comment->create_many( 3, array( 'comment_post_ID' => $this->post_id ) );
+
+        $q = new WP_Comment_Query( array(
+            'post_id' => $this->post_id,
+            'number' => 2,
+            'no_found_rows' => false,
+        ) );
+
+        $this->assertEquals( 3, $q->found_comments );
+        $this->assertEquals( 2, $q->max_num_pages );
+    }
 }