Changeset 34545

Timestamp:

09/25/2015 02:42:48 PM (9 years ago)

Author:

boonebgorges

Message:

Improve status checks when sending comment post author notification.

[34537] hooked wp_new_comment_notify_postauthor() to the
'wp_set_comment_status' when a comment had been approved. When performing
multiple actions on a comment in the same request (as happens in
Tests_Ajax_DeleteComment::test_ajax_trash_double_action(), and may happen
sometimes in real life too), and when one of those actions involves deleting
the comment, the $comment_ID passed to wp_new_comment_notify_postauthor()
can correspond to an already-deleted comment. The comment_status check should
account for this possibility.

See #14078.

File:

• trunk/src/wp-includes/comment-functions.php (modified) (1 diff)

trunk/src/wp-includes/comment-functions.php

@@ -1738 +1738 @@
 
     // Only send notifications for approved comments.
-    if ( 'spam' === $comment->comment_approved || ! $comment->comment_approved ) {
+    if ( ! isset( $comment->comment_approved ) || 'spam' === $comment->comment_approved || ! $comment->comment_approved ) {
         return false;
     }