Changeset 34563 for trunk/src/wp-admin/includes/widgets.php

Timestamp:

09/25/2015 09:01:46 PM (10 years ago)

Author:

westonruter

Message:

Customizer: Defer embedding widget controls to improve DOM performance and initial load time.

The Menu Customizer feature includes a performance technique whereby the controls for nav menu items are only embedded into the DOM once the containing menu section is expanded. This commit implements the same DOM deferral for widgets but goes a step further than just embedding the controls once the widget area's Customizer section is expanded: it also defers the embedding of the widget control's form until the widget is expanded, at which point the widget-added event also fires to allow any additional widget initialization to be done. The deferred DOM embedding can speed up initial load time by 10x or more. This DOM deferral also yields a reduction in overall memory usage in the browser process.

Includes changes to wp_widget_control() to facilitate separating out the widget form from the surrounding accordion container; also includes unit tests for this previously-untested function. Also included are initial QUnit tests (finally) for widgets in the Customizer.

Fixes #33901.

File:

• trunk/src/wp-admin/includes/widgets.php (modified) (3 diffs)

trunk/src/wp-admin/includes/widgets.php

@@ -182 +182 @@
     $add_new = isset($sidebar_args['_add']) ? $sidebar_args['_add'] : '';
 
+    $before_form = isset( $sidebar_args['before_form'] ) ? $sidebar_args['before_form'] : '<form method="post">';
+    $after_form = isset( $sidebar_args['after_form'] ) ? $sidebar_args['after_form'] : '</form>';
+    $before_widget_content = isset( $sidebar_args['before_widget_content'] ) ? $sidebar_args['before_widget_content'] : '<div class="widget-content">';
+    $after_widget_content = isset( $sidebar_args['after_widget_content'] ) ? $sidebar_args['after_widget_content'] : '</div>';
+
     $query_arg = array( 'editwidget' => $widget['id'] );
     if ( $add_new ) {
@@ -226 +231 @@
 
     <div class="widget-inside">
-    <form method="post">
-    <div class="widget-content">
-<?php
-    if ( isset($control['callback']) )
+    <?php echo $before_form; ?>
+    <?php echo $before_widget_content; ?>
+    <?php
+    if ( isset( $control['callback'] ) ) {
         $has_form = call_user_func_array( $control['callback'], $control['params'] );
-    else
-        echo "\t\t<p>" . __('There are no options for this widget.') . "</p>\n"; ?>
-    </div>
+    } else {
+        echo "\t\t<p>" . __('There are no options for this widget.') . "</p>\n";
+    }
+    ?>
+    <?php echo $after_widget_content; ?>
     <input type="hidden" name="widget-id" class="widget-id" value="<?php echo esc_attr($id_format); ?>" />
     <input type="hidden" name="id_base" class="id_base" value="<?php echo esc_attr($id_base); ?>" />
@@ -253 +260 @@
         <br class="clear" />
     </div>
-    </form>
+    <?php echo $after_form; ?>
     </div>