Changeset 34575

Timestamp:

09/26/2015 04:44:51 AM (9 years ago)

Author:

wonderboymusic

Message:

XML-RPC: In wp_xmlrpc_server::wp_getComments(), allow post_type to be passed as part of $struct.

Props nprasath002.
Fixes #20026.

File:

• trunk/src/wp-includes/class-wp-xmlrpc-server.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-xmlrpc-server.php

@@ -3215 +3215 @@
         $struct   = isset( $args[3] ) ? $args[3] : array();
 
-        if ( ! $user = $this->login($username, $password ) )
-            return $this->error;
+        if ( ! $user = $this->login( $username, $password ) ) {
+            return $this->error;
+        }
 
         /** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
         do_action( 'xmlrpc_call', 'wp.getComments' );
 
-        if ( isset( $struct['status'] ) )
+        if ( isset( $struct['status'] ) ) {
             $status = $struct['status'];
-        else
+        } else {
             $status = '';
+        }
 
         if ( ! current_user_can( 'moderate_comments' ) && 'approve' !== $status ) {
@@ -3231 +3233 @@
 
         $post_id = '';
-        if ( isset($struct['post_id']) )
-            $post_id = absint($struct['post_id']);
+        if ( isset( $struct['post_id'] ) ) {
+            $post_id = absint( $struct['post_id'] );
+        }
+
+        $post_type = '';
+        if ( isset( $struct['post_type'] ) ) {
+            $post_type_object = get_post_type_object( $struct['post_type'] );
+            if ( ! $post_type_object || ! post_type_supports( $post_type_object->name, 'comments' ) ) {
+                return new IXR_Error( 404, __( 'Invalid post type.' ) );
+            }
+            $post_type = $struct['post_type'];
+        }
 
         $offset = 0;
-        if ( isset($struct['offset']) )
-            $offset = absint($struct['offset']);
+        if ( isset( $struct['offset'] ) ) {
+            $offset = absint( $struct['offset'] );
+        }
 
         $number = 10;
-        if ( isset($struct['number']) )
-            $number = absint($struct['number']);
-
-        $comments = get_comments( array( 'status' => $status, 'post_id' => $post_id, 'offset' => $offset, 'number' => $number ) );
+        if ( isset( $struct['number'] ) ) {
+            $number = absint( $struct['number'] );
+        }
+
+        $comments = get_comments( array(
+            'status' => $status,
+            'post_id' => $post_id,
+            'offset' => $offset,
+            'number' => $number,
+            'post_type' => $post_type,
+        ) );
 
         $comments_struct = array();