Changeset 34581

Timestamp:

09/26/2015 06:00:09 AM (11 years ago)

Author:

wonderboymusic

Message:

Recent Comments Widget: a la [34464], this widget has the same mixed content issues. Remove the fragment caching. The comment queries are now split to scale. This was the only remaining widget with an HTML fragment cache.

Fixes #25556.

File:

• trunk/src/wp-includes/widgets/class-wp-widget-recent-comments.php (modified) (4 diffs)

trunk/src/wp-includes/widgets/class-wp-widget-recent-comments.php

@@ -24 +24 @@
                 if ( is_active_widget(false, false, $this->id_base) )
                         add_action( 'wp_head', array($this, 'recent_comments_style') );
-
-                add_action( 'comment_post', array($this, 'flush_widget_cache') );
-                add_action( 'edit_comment', array($this, 'flush_widget_cache') );
-                add_action( 'transition_comment_status', array($this, 'flush_widget_cache') );
         }
 
@@ -51 +47 @@
 
         /**
-         * @access public
-         */
-        public function flush_widget_cache() {
-                wp_cache_delete('widget_recent_comments', 'widget');
-        }
-
-        /**
          * @param array $args
          * @param array $instance
          */
         public function widget( $args, $instance ) {
-                $cache = array();
-                if ( ! $this->is_preview() ) {
-                        $cache = wp_cache_get('widget_recent_comments', 'widget');
-                }
-                if ( ! is_array( $cache ) ) {
-                        $cache = array();
-                }
-
                 if ( ! isset( $args['widget_id'] ) )
                         $args['widget_id'] = $this->id;
-
-                if ( isset( $cache[ $args['widget_id'] ] ) ) {
-                        echo $cache[ $args['widget_id'] ];
-                        return;
-                }
 
                 $output = '';
@@ -129 +105 @@
 
                 echo $output;
-
-                if ( ! $this->is_preview() ) {
-                        $cache[ $args['widget_id'] ] = $output;
-                        wp_cache_set( 'widget_recent_comments', $cache, 'widget' );
-                }
         }
 
@@ -145 +116 @@
                 $instance['title'] = sanitize_text_field( $new_instance['title'] );
                 $instance['number'] = absint( $new_instance['number'] );
-                $this->flush_widget_cache();
-
-                $alloptions = wp_cache_get( 'alloptions', 'options' );
-                if ( isset($alloptions['widget_recent_comments']) )
-                        delete_option('widget_recent_comments');
-
                 return $instance;
         }