Changeset 34584

Timestamp:

09/26/2015 06:50:03 AM (11 years ago)

Author:

wonderboymusic

Message:

Posts List Table: check is_multi_author() before attempting to set ->user_posts_count. Also, don't show "Mine" when the count is the same as "All."

Fixes #19609.

File:

• trunk/src/wp-admin/includes/class-wp-posts-list-table.php (modified) (4 diffs)

trunk/src/wp-admin/includes/class-wp-posts-list-table.php

@@ -80 +80 @@
                 $post_type        = $this->screen->post_type;
                 $post_type_object = get_post_type_object( $post_type );
-                $exclude_states   = get_post_stati( array(
-                        'show_in_admin_all_list' => false,
-                ) );
-                $this->user_posts_count = $wpdb->get_var( $wpdb->prepare( "
-                        SELECT COUNT( 1 )
-                        FROM $wpdb->posts
-                        WHERE post_type = %s
-                        AND post_status NOT IN ( '" . implode( "','", $exclude_states ) . "' )
-                        AND post_author = %d
-                ", $post_type, get_current_user_id() ) );
+
+                if ( is_multi_author() ) {
+                        $exclude_states   = get_post_stati( array(
+                                'show_in_admin_all_list' => false,
+                        ) );
+                        $this->user_posts_count = $wpdb->get_var( $wpdb->prepare( "
+                                SELECT COUNT( 1 )
+                                FROM $wpdb->posts
+                                WHERE post_type = %s
+                                AND post_status NOT IN ( '" . implode( "','", $exclude_states ) . "' )
+                                AND post_author = %d
+                        ", $post_type, get_current_user_id() ) );
+                }
 
                 if ( $this->user_posts_count && ! current_user_can( $post_type_object->cap->edit_others_posts ) && empty( $_REQUEST['post_status'] ) && empty( $_REQUEST['all_posts'] ) && empty( $_REQUEST['author'] ) && empty( $_REQUEST['show_sticky'] ) ) {
@@ -261 +264 @@
                 $status_links = array();
                 $num_posts = wp_count_posts( $post_type, 'readable' );
+                $total_posts = array_sum( (array) $num_posts );
                 $class = '';
 
@@ -267 +271 @@
                 $mine = '';
 
-                if ( $this->user_posts_count ) {
+                if ( $this->user_posts_count && $this->user_posts_count !== $total_posts ) {
                         if ( isset( $_GET['author'] ) && ( $_GET['author'] == $current_user_id ) ) {
                                 $class = 'current';
@@ -292 +296 @@
                         $class = '';
                 }
-
-                $total_posts = array_sum( (array) $num_posts );
 
                 // Subtract post types that are not included in the admin all list.