Changeset 34598 for trunk/src/wp-admin/update.php

Timestamp:

09/26/2015 03:49:06 PM (11 years ago)

Author:

ocean90

Message:

Plugins: Don't request all fields via plugins_api( 'plugin_information' ) for plugin installs and update checks.

The Plugins API returns a lot of data by default (see [34596]) but when installing or checking for updates we don't need all of it. To save bandwidth, memory and time request only required fields.

Fixes #34030.

File:

• trunk/src/wp-admin/update.php (modified) (1 diff)

trunk/src/wp-admin/update.php

@@ -98 +98 @@
                 include_once( ABSPATH . 'wp-admin/includes/plugin-install.php' ); //for plugins_api..
 
-                check_admin_referer('install-plugin_' . $plugin);
-                $api = plugins_api('plugin_information', array('slug' => $plugin, 'fields' => array('sections' => false) ) ); //Save on a bit of bandwidth.
-
-                if ( is_wp_error($api) )
-                        wp_die($api);
+                check_admin_referer( 'install-plugin_' . $plugin );
+                $api = plugins_api( 'plugin_information', array(
+                        'slug' => $plugin,
+                        'fields' => array(
+                                'short_description' => false,
+                                'sections' => false,
+                                'requires' => false,
+                                'rating' => false,
+                                'ratings' => false,
+                                'downloaded' => false,
+                                'last_updated' => false,
+                                'added' => false,
+                                'tags' => false,
+                                'compatibility' => false,
+                                'homepage' => false,
+                                'donate_link' => false,
+                        ),
+                ) );
+
+                if ( is_wp_error( $api ) ) {
+                        wp_die( $api );
+                }
 
                 $title = __('Plugin Install');