Changeset 34599 for trunk/src/wp-includes/class-wp-comment.php

Timestamp:

09/26/2015 04:01:05 PM (11 years ago)

Author:

boonebgorges

Message:

Improve post field lazyloading for comments.

[34583] modified comment queries so that all post fields are no longer loaded
by default. Instead, they are loaded only when requested on individual comment
objects. This changeset improves that flow:

• WP_Comment magic methods __isset() and __get() should only load the post when a post field is being requested.
• The new update_comment_post_cache argument for WP_Comment_Query allows developers to specify that, when comments are queried, all of the posts matching those comments should be loaded into cache with a single DB hit. This parameter defaults to false, since typical comment queries are linked to a single post.

Fixes #27571.

File:

• trunk/src/wp-includes/class-wp-comment.php (modified) (4 diffs)

trunk/src/wp-includes/class-wp-comment.php

@@ -158 +158 @@
          */
         protected $children;
+
+        /**
+         * Post fields.
+         *
+         * @since 4.4.0
+         * @access protected
+         * @var array
+         */
+        protected $post_fields = array( 'post_author', 'post_date', 'post_date_gmt', 'post_content', 'post_title', 'post_excerpt', 'post_status', 'comment_status', 'ping_status', 'post_name', 'to_ping', 'pinged', 'post_modified', 'post_modified_gmt', 'post_content_filtered', 'post_parent', 'guid', 'menu_order', 'post_type', 'post_mime_type', 'comment_count' );
 
         /**
@@ -323 +332 @@
 
         /**
-         * Whether a comment has post from which to retrieve magic properties
-         *
-         * @since 4.4.0
-         * @access public
-         *
-         * @param string $name
+         * Check whether a non-public property is set.
+         *
+         * If `$name` matches a post field, the comment post will be loaded and the post's value checked.
+         *
+         * @since 4.4.0
+         * @access public
+         *
+         * @param string $name Property name.
          * @return bool
          */
         public function __isset( $name ) {
-                if (
-                        0 === (int) $this->comment_post_ID
-                        || property_exists( $this, $name )
-                ) {
-                        return;
-                }
-
-                $post = get_post( $this->comment_post_ID );
-                if ( $post ) {
+                if ( in_array( $name, $this->post_fields ) && 0 !== (int) $this->comment_post_ID ) {
+                        $post = get_post( $this->comment_post_ID );
                         return property_exists( $post, $name );
                 }
@@ -346 +350 @@
 
         /**
-         * Magic getter for $post properties
+         * Magic getter.
+         *
+         * If `$name` matches a post field, the comment post will be loaded and the post's value returned.
          *
          * @since 4.4.0
@@ -355 +361 @@
          */
         public function __get( $name ) {
-                $post = get_post( $this->comment_post_ID );
-                if ( $post ) {
+                if ( in_array( $name, $this->post_fields ) ) {
+                        $post = get_post( $this->comment_post_ID );
                         return $post->$name;
                 }