Changeset 34606

Timestamp:

09/26/2015 08:58:22 PM (9 years ago)

Author:

jorbin

Message:

Revert change from true to false in multisite upload test

This change was introduced in [34601]. 0 is a special snowflake. The code treats it as if it should fall back to the default, rather than respecting 0 as 0. Essentially, 0 means 100. WAT? This has been discussed previusly in https://core.trac.wordpress.org/ticket/19538#comment:10. This test should return True right now, but the behavior should be discussed and in the future 0 may mean 0.

See #34037
Props jorbin, boonebgorges

File:

• trunk/tests/phpunit/tests/multisite/site.php (modified) (1 diff)

trunk/tests/phpunit/tests/multisite/site.php

@@ -1108 +1108 @@
         update_site_option( 'upload_space_check_disabled', false );
         update_site_option( 'blog_upload_space', 0 );
-        $this->assertFalse( is_upload_space_available() );
+        $this->assertTrue( is_upload_space_available() );
     }