Changeset 34630

Timestamp:

09/27/2015 06:12:20 PM (10 years ago)

Author:

wonderboymusic

Message:

Nav Menus: in wp_nav_menu(), $container is already bound to a list of allowed tags. PHP, being its whimsical self, while return true if someone sets $container to true via in_array( true, [ 'div', 'nav' ] ). Check that $container is a string before the in_array() check. 'true' does not pass.

Props shedonist for the original patch.
Fixes #32464.

File:

• trunk/src/wp-includes/nav-menu-template.php (modified) (1 diff)

trunk/src/wp-includes/nav-menu-template.php

@@ -335 +335 @@
          */
         $allowed_tags = apply_filters( 'wp_nav_menu_container_allowedtags', array( 'div', 'nav' ) );
-        if ( in_array( $args->container, $allowed_tags ) ) {
+        if ( is_string( $args->container ) && in_array( $args->container, $allowed_tags ) ) {
             $show_container = true;
             $class = $args->container_class ? ' class="' . esc_attr( $args->container_class ) . '"' : ' class="menu-'. $menu->slug .'-container"';