Changeset 34646 for trunk/tests/phpunit/tests/term/wpInsertTerm.php

Timestamp:

09/27/2015 10:26:16 PM (11 years ago)

Author:

johnbillion

Message:

Switch several assertions to assertNotWPError() so more context is provided when the assertion fails.

File:

• trunk/tests/phpunit/tests/term/wpInsertTerm.php (modified) (8 diffs)

trunk/tests/phpunit/tests/term/wpInsertTerm.php

@@ -28 +28 @@
                 $t = wp_insert_term( $term, $taxonomy );
                 $this->assertInternalType( 'array', $t );
-                $this->assertFalse( is_wp_error($t) );
+                $this->assertNotWPError( $t );
                 $this->assertTrue( $t['term_id'] > 0 );
                 $this->assertTrue( $t['term_taxonomy_id'] > 0 );
@@ -162 +162 @@
         public function test_wp_insert_term_duplicate_name() {
                 $term = $this->factory->tag->create_and_get( array( 'name' => 'Bozo' ) );
-                $this->assertFalse( is_wp_error( $term ) );
+                $this->assertNotWPError( $term );
                 $this->assertTrue( empty( $term->errors ) );
 
                 // Test existing term name with unique slug
                 $term1 = $this->factory->tag->create( array( 'name' => 'Bozo', 'slug' => 'bozo1' ) );
-                $this->assertFalse( is_wp_error( $term1 ) );
+                $this->assertNotWPError( $term1 );
 
                 // Test an existing term name
@@ -201 +201 @@
 
                 $term13 = $this->factory->tag->create( array( 'name' => 'A' ) );
-                $this->assertFalse( is_wp_error( $term13 ) );
+                $this->assertNotWPError( $term13 );
                 $term14 = $this->factory->tag->create( array( 'name' => 'A' ) );
                 $this->assertTrue( is_wp_error( $term14 ) );
                 $term15 = $this->factory->tag->create( array( 'name' => 'A+', 'slug' => 'a' ) );
-                $this->assertFalse( is_wp_error( $term15 ) );
+                $this->assertNotWPError( $term15 );
                 $term16 = $this->factory->tag->create( array( 'name' => 'A+' ) );
                 $this->assertTrue( is_wp_error( $term16 ) );
                 $term17 = $this->factory->tag->create( array( 'name' => 'A++' ) );
-                $this->assertFalse( is_wp_error( $term17 ) );
+                $this->assertNotWPError( $term17 );
                 $term18 = $this->factory->tag->create( array( 'name' => 'A-', 'slug' => 'a' ) );
-                $this->assertFalse( is_wp_error( $term18 ) );
+                $this->assertNotWPError( $term18 );
                 $term19 = $this->factory->tag->create( array( 'name' => 'A-' ) );
                 $this->assertTrue( is_wp_error( $term19 ) );
                 $term20 = $this->factory->tag->create( array( 'name' => 'A--' ) );
-                $this->assertFalse( is_wp_error( $term20 ) );
+                $this->assertNotWPError( $term20 );
         }
 
@@ -277 +277 @@
                 ) );
 
-                $this->assertFalse( is_wp_error( $t2 ) );
+                $this->assertNotWPError( $t2 );
 
                 $t2_term = get_term( $t2['term_id'], 'wptests_tax' );
@@ -369 +369 @@
                 ) );
 
-                $this->assertFalse( is_wp_error( $t4 ) );
+                $this->assertNotWPError( $t4 );
                 $t4_term = get_term( $t4['term_id'], 'wptests_tax' );
 
@@ -392 +392 @@
                 ) );
 
-                $this->assertFalse( is_wp_error( $t2 ) );
+                $this->assertNotWPError( $t2 );
 
                 $t2_term = get_term( $t2['term_id'], 'wptests_tax' );
@@ -456 +456 @@
                 ) );
 
-                $this->assertFalse( is_wp_error( $created ) );
+                $this->assertNotWPError( $created );
 
                 $new_term = get_term( $created['term_id'], 'wptests_tax_2' );
@@ -487 +487 @@
                 ) );
 
-                $this->assertFalse( is_wp_error( $created ) );
+                $this->assertNotWPError( $created );
 
                 $new_term = get_term( $created['term_id'], 'wptests_tax_2' );