Changeset 34655 for trunk/src/wp-includes/wp-db.php

Timestamp:

09/28/2015 01:16:29 AM (10 years ago)

Author:

pento

Message:

WPDB: Make sure we don't run sanity checks on DB dropins.

Previously, we'd run the sanity checks if is_mysql was not set to false. This caused problems for DB drop-ins that didn't define is_mysql at all. Instead, we can just check if is_mysql is empty().

Also fix some unit tests that accidently ran correctly because of the strict false === comparison.

Fixes #33501.

File:

• trunk/src/wp-includes/wp-db.php (modified) (2 diffs)

trunk/src/wp-includes/wp-db.php

@@ -2415 +2415 @@
 
         // Skip this entirely if this isn't a MySQL database.
-        if ( false === $this->is_mysql ) {
+        if ( empty( $this->is_mysql ) ) {
             return false;
         }
@@ -2464 +2464 @@
 
         // Skip this entirely if this isn't a MySQL database.
-        if ( false === $this->is_mysql ) {
+        if ( empty( $this->is_mysql ) ) {
             return false;
         }