Changeset 34658

Timestamp:

09/28/2015 03:10:08 AM (9 years ago)

Author:

wonderboymusic

Message:

Theme Editor: ensure that files named index.php in theme subfolders are not labeled as "Main Index Template"

Props MikeHansenMe, wonderboymusic, bravokeyl, Shelob9.
Fixes #27201.

Location:

trunk/src/wp-admin

Files:

• includes/file.php (modified) (1 diff)
• theme-editor.php (modified) (3 diffs)

trunk/src/wp-admin/includes/file.php

@@ -52 +52 @@
  * @global array $wp_file_descriptions
  * @param string $file Filesystem path or filename
- * @return string Description of file from $wp_file_descriptions or basename of $file if description doesn't exist
+ * @return string Description of file from $wp_file_descriptions or basename of $file if description doesn't exist.
+ *                Appends 'Page Template' to basename of $file if the file is a page template
  */
 function get_file_description( $file ) {
-    global $wp_file_descriptions;
-
-    if ( isset( $wp_file_descriptions[basename( $file )] ) ) {
-        return $wp_file_descriptions[basename( $file )];
-    }
-    elseif ( file_exists( $file ) && is_file( $file ) ) {
-        $template_data = implode( '', file( $file ) );
-        if ( preg_match( '|Template Name:(.*)$|mi', $template_data, $name ))
-            return sprintf( __( '%s Page Template' ), _cleanup_header_comment($name[1]) );
+    global $wp_file_descriptions, $allowed_files;
+
+    $relative_pathinfo = pathinfo( $file );
+    $file_path = $allowed_files[ $file ];
+    if ( isset( $wp_file_descriptions[ basename( $file ) ] ) && '.' === $relative_pathinfo['dirname'] ) {
+        return $wp_file_descriptions[ basename( $file ) ];
+    } elseif ( file_exists( $file_path ) && is_file( $file_path ) ) {
+        $template_data = implode( '', file( $file_path ) );
+        if ( preg_match( '|Template Name:(.*)$|mi', $template_data, $name ) ) {
+            return sprintf( __( '%s Page Template' ), _cleanup_header_comment( $name[1] ) );
+        }
     }
 

trunk/src/wp-admin/theme-editor.php

@@ -26 +26 @@
 'content'   =>
     '<p>' . __('You can use the Theme Editor to edit the individual CSS and PHP files which make up your theme.') . '</p>
-    <p>' . __('Begin by choosing a theme to edit from the dropdown menu and clicking Select. A list then appears of all the template files. Clicking once on any file name causes the file to appear in the large Editor box.') . '</p>
+    <p>' . __("Begin by choosing a theme to edit from the dropdown menu and clicking Select. A list then appears of the theme's template files. Clicking once on any file name causes the file to appear in the large Editor box.") . '</p>
     <p>' . __('For PHP files, you can use the Documentation dropdown to select from functions recognized in that file. Look Up takes you to a web page with reference material about that particular function.') . '</p>
     <p id="newcontent-description">' . __( 'In the editing area the Tab key enters a tab character. To move below this area by pressing Tab, press the Esc key followed by the Tab key. In some cases the Esc key will need to be pressed twice before the Tab key will allow you to continue.' ) . '</p>
@@ -126 +126 @@
 <?php endif;
 
-$description = get_file_description( $file );
+$description = get_file_description( $relative_file );
 $file_show = array_search( $file, array_filter( $allowed_files ) );
 if ( $description != $file_show )
@@ -178 +178 @@
             echo "\t</ul>\n\t<h2>" . _x( 'Styles', 'Theme stylesheets in theme editor' ) . "</h2>\n\t<ul>\n";
 
-        $file_description = get_file_description( $absolute_filename );
-        if ( $file_description != basename( $filename ) )
+        $file_description = get_file_description( $filename );
+        if ( $filename !== basename( $absolute_filename ) || $file_description !== $filename ) {
             $file_description .= '<br /><span class="nonessential">(' . $filename . ')</span>';
-
-        if ( $absolute_filename == $file )
+        }
+
+        if ( $absolute_filename === $file ) {
             $file_description = '<span class="highlight">' . $file_description . '</span>';
+        }
 ?>
         <li><a href="theme-editor.php?file=<?php echo urlencode( $filename ) ?>&amp;theme=<?php echo urlencode( $stylesheet ) ?>"><?php echo $file_description; ?></a></li>