Changeset 34667 for trunk/src/wp-admin/includes/class-wp-posts-list-table.php

Timestamp:

09/28/2015 07:14:56 PM (9 years ago)

Author:

johnbillion

Message:

Correct the logic used when determining whether to display the 'Mine' link on post list tables. It should only be shown when the count for the user's posts differs for the total count of posts. is_multi_author() cannot be used because it only considers Posts.

Fixes #19609

File:

• trunk/src/wp-admin/includes/class-wp-posts-list-table.php (modified) (3 diffs)

trunk/src/wp-admin/includes/class-wp-posts-list-table.php

@@ -81 +81 @@
         $post_type_object = get_post_type_object( $post_type );
 
-        if ( is_multi_author() ) {
-            $exclude_states   = get_post_stati( array(
-                'show_in_admin_all_list' => false,
-            ) );
-            $this->user_posts_count = $wpdb->get_var( $wpdb->prepare( "
-                SELECT COUNT( 1 )
-                FROM $wpdb->posts
-                WHERE post_type = %s
-                AND post_status NOT IN ( '" . implode( "','", $exclude_states ) . "' )
-                AND post_author = %d
-            ", $post_type, get_current_user_id() ) );
-        }
+        $exclude_states   = get_post_stati( array(
+            'show_in_admin_all_list' => false,
+        ) );
+        $this->user_posts_count = intval( $wpdb->get_var( $wpdb->prepare( "
+            SELECT COUNT( 1 )
+            FROM $wpdb->posts
+            WHERE post_type = %s
+            AND post_status NOT IN ( '" . implode( "','", $exclude_states ) . "' )
+            AND post_author = %d
+        ", $post_type, get_current_user_id() ) ) );
 
         if ( $this->user_posts_count && ! current_user_can( $post_type_object->cap->edit_others_posts ) && empty( $_REQUEST['post_status'] ) && empty( $_REQUEST['all_posts'] ) && empty( $_REQUEST['author'] ) && empty( $_REQUEST['show_sticky'] ) ) {
@@ -270 +268 @@
         $all_args = array( 'post_type' => $post_type );
         $mine = '';
+
+        // Subtract post types that are not included in the admin all list.
+        foreach ( get_post_stati( array( 'show_in_admin_all_list' => false ) ) as $state ) {
+            $total_posts -= $num_posts->$state;
+        }
 
         if ( $this->user_posts_count && $this->user_posts_count !== $total_posts ) {
@@ -296 +299 @@
             $class = '';
         }
-
-        // Subtract post types that are not included in the admin all list.
-        foreach ( get_post_stati( array('show_in_admin_all_list' => false) ) as $state )
-            $total_posts -= $num_posts->$state;
 
         if ( empty( $class ) && ( ( $this->is_base_request() && ! $this->user_posts_count ) || isset( $_REQUEST['all_posts'] ) ) ) {