Changeset 34690 for trunk/src/wp-includes/link-template.php

Timestamp:

09/29/2015 09:41:14 AM (10 years ago)

Author:

pento

Message:

Permalinks: Add pretty permalinks for unattached attachments.

Previously, unattached attachments would have unsightly /?attachment_id=1 URLs. As we've moved away from attachments being specifically attached to posts, instead being Media items, this has made the unattached URLs a more common occurrence.

We can breath easy once more, knowing that the world is a little bit safer from the horror of unnecessarily ugly URLs.

Props SergeyBiryukov, wonderboymusic, pento.

Fixes #1914.

File:

• trunk/src/wp-includes/link-template.php (modified) (2 diffs)

trunk/src/wp-includes/link-template.php

@@ -387 +387 @@
     $post = get_post( $post );
     $parent = ( $post->post_parent > 0 && $post->post_parent != $post->ID ) ? get_post( $post->post_parent ) : false;
+    if ( $parent && ! in_array( $parent->post_type, get_post_types() ) ) {
+        $parent = false;
+    }
 
     if ( $wp_rewrite->using_permalinks() && $parent ) {
@@ -404 +407 @@
         if ( ! $leavename )
             $link = str_replace( '%postname%', $name, $link );
+    } elseif ( $wp_rewrite->using_permalinks() && ! $leavename ) {
+        $link = home_url( user_trailingslashit( $post->post_name ) );
     }