Changeset 34690 for trunk/src/wp-includes/query.php

Timestamp:

09/29/2015 09:41:14 AM (9 years ago)

Author:

pento

Message:

Permalinks: Add pretty permalinks for unattached attachments.

Previously, unattached attachments would have unsightly /?attachment_id=1 URLs. As we've moved away from attachments being specifically attached to posts, instead being Media items, this has made the unattached URLs a more common occurrence.

We can breath easy once more, knowing that the world is a little bit safer from the horror of unnecessarily ugly URLs.

Props SergeyBiryukov, wonderboymusic, pento.

Fixes #1914.

File:

• trunk/src/wp-includes/query.php (modified) (1 diff)

trunk/src/wp-includes/query.php

@@ -3581 +3581 @@
         if ( !empty($this->posts) && ($this->is_single || $this->is_page) ) {
             $status = get_post_status($this->posts[0]);
+            if ( 'attachment' === $this->posts[0]->post_type && 0 === (int) $this->posts[0]->post_parent ) {
+                $this->is_page = false;
+                $this->is_single = true;
+                $this->is_attachment = true;
+            }
             $post_status_obj = get_post_status_object($status);
             //$type = get_post_type($this->posts[0]);