Changeset 34690 for trunk/tests/phpunit/tests/link.php

Timestamp:

09/29/2015 09:41:14 AM (9 years ago)

Author:

pento

Message:

Permalinks: Add pretty permalinks for unattached attachments.

Previously, unattached attachments would have unsightly /?attachment_id=1 URLs. As we've moved away from attachments being specifically attached to posts, instead being Media items, this has made the unattached URLs a more common occurrence.

We can breath easy once more, knowing that the world is a little bit safer from the horror of unnecessarily ugly URLs.

Props SergeyBiryukov, wonderboymusic, pento.

Fixes #1914.

File:

• trunk/tests/phpunit/tests/link.php (modified) (1 diff)

trunk/tests/phpunit/tests/link.php

@@ -396 +396 @@
         $this->assertEquals( $non_pretty_permalink, get_permalink( $p ) );
     }
+
+    /**
+     * @ticket 1914
+     */
+    public function test_unattached_attachment_has_a_pretty_permalink() {
+        global $wp_rewrite;
+        $wp_rewrite->set_permalink_structure('/%year%/%monthnum%/%day%/%postname%/');
+        $wp_rewrite->flush_rules();
+
+        $attachment_id = $this->factory->attachment->create_object( 'image.jpg', 0, array(
+            'post_mime_type' => 'image/jpeg',
+            'post_type' => 'attachment',
+            'post_title' => 'An Attachment!',
+            'post_status' => 'inherit',
+        ) );
+
+        $attachment = get_post( $attachment_id );
+
+        $this->assertSame( home_url( user_trailingslashit( $attachment->post_name ) ), get_permalink( $attachment_id ) );
+    }
+
+    /**
+     * @ticket 1914
+     */
+    public function test_attachment_attached_to_non_existent_post_type_has_a_pretty_permalink() {
+        global $wp_rewrite, $wp_post_types;
+        $wp_rewrite->set_permalink_structure('/%year%/%monthnum%/%day%/%postname%/');
+
+        register_post_type( 'not_a_post_type', array( 'public' => true ) );
+
+        $wp_rewrite->flush_rules();
+
+        $post_id = $this->factory->post->create( array( 'post_type' => 'not_a_post_type' ) );
+
+        $attachment_id = $this->factory->attachment->create_object( 'image.jpg', $post_id, array(
+            'post_mime_type' => 'image/jpeg',
+            'post_type' => 'attachment',
+            'post_title' => 'An Attachment!',
+            'post_status' => 'inherit',
+        ) );
+
+        $attachment = get_post( $attachment_id );
+
+        $this->assertSame( get_permalink( $post_id ) . user_trailingslashit( $attachment->post_name ), get_permalink( $attachment_id ) );
+
+        foreach( $wp_post_types as $id => $pt ) {
+            if ( 'not_a_post_type' === $pt->name ) {
+                unset( $wp_post_types[ $id ] );
+                break;
+            }
+        }
+
+        $this->assertSame( home_url( user_trailingslashit( $attachment->post_name ) ), get_permalink( $attachment_id ) );
+    }
 }