Changeset 34708 for trunk/tests/phpunit/tests/rewrite.php

Timestamp:

09/30/2015 01:10:03 AM (9 years ago)

Author:

wonderboymusic

Message:

Rewrite: allow add_rewrite_rule|WP_Rewrite::add_rule() to accept an associative array for the value of $redirect instead of requiring a query string.

Adds unit tests.

Props scribu, DrewAPicture.
Fixes #16840.

File:

• trunk/tests/phpunit/tests/rewrite.php (modified) (1 diff)

trunk/tests/phpunit/tests/rewrite.php

@@ -32 +32 @@
     }
 
+    /**
+     * @ticket 16840
+     */
+    public function test_add_rule() {
+        global $wp_rewrite;
+
+        $pattern  = 'path/to/rewrite/([^/]+)/?$';
+        $redirect = 'index.php?test_var1=$matches[1]&test_var2=1';
+
+        $wp_rewrite->add_rule( $pattern, $redirect );
+
+        $wp_rewrite->flush_rules();
+
+        $rewrite_rules = $wp_rewrite->rewrite_rules();
+
+        $this->assertSame( $redirect, $rewrite_rules[ $pattern ] );
+    }
+
+    /**
+     * @ticket 16840
+     */
+    public function test_add_rule_redirect_array() {
+        global $wp_rewrite;
+
+        $pattern  = 'path/to/rewrite/([^/]+)/?$';
+        $redirect = 'index.php?test_var1=$matches[1]&test_var2=1';
+
+        $wp_rewrite->add_rule( $pattern, array(
+            'test_var1' => '$matches[1]',
+            'test_var2' => '1'
+        ) );
+
+        $wp_rewrite->flush_rules();
+
+        $rewrite_rules = $wp_rewrite->rewrite_rules();
+
+        $this->assertSame( $redirect, $rewrite_rules[ $pattern ] );
+    }
+
+    /**
+     * @ticket 16840
+     */
+    public function test_add_rule_top() {
+        global $wp_rewrite;
+
+        $pattern  = 'path/to/rewrite/([^/]+)/?$';
+        $redirect = 'index.php?test_var1=$matches[1]&test_var2=1';
+
+        $wp_rewrite->add_rule( $pattern, $redirect, 'top' );
+
+        $wp_rewrite->flush_rules();
+
+        $extra_rules_top = $wp_rewrite->extra_rules_top;
+
+        $this->assertContains( $redirect, $extra_rules_top[ $pattern ] );
+    }
+
     function test_url_to_postid() {