Changeset 34728 for trunk/src/wp-admin/includes/class-wp-list-table.php

Timestamp:

10/01/2015 02:09:41 AM (11 years ago)

Author:

wonderboymusic

Message:

Post List Table: Ensure that edit.php with no query string produces the proper markup and links in the date column header.

Add 2 methods to WP_List_Table, ->get_orderby() and ->get_order(). Override the methods in WP_Posts_List_Table.

WP_Posts_List_Table calls wp_edit_posts_query() in ->prepare_items() which is a wrapper for wp(). As such, we can obtain orderby and order via get_query_var(), instead of the URL.

Fixes #25493.

File:

• trunk/src/wp-admin/includes/class-wp-list-table.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-list-table.php

@@ -1008 +1008 @@
 
         /**
+         * If 'orderby' is set, return it.
+         *
+         * @access protected
+         * @since 4.4.0
+         *
+         * @return string The value of 'orderby' or empty string.
+         */
+        protected function get_orderby() {
+                if ( isset( $_GET['orderby'] ) ) {
+                        return $_GET['orderby'];
+                }
+
+                return '';
+        }
+
+        /**
+         * If 'order' is 'desc', return it. Else return 'asc'.
+         *
+         * @access protected
+         * @since 4.4.0
+         *
+         * @return string 'desc' or 'asc'.
+         */
+        protected function get_order() {
+                if ( isset( $_GET['order'] ) && 'desc' === $_GET['order'] ) {
+                        return 'desc';
+                }
+
+                return 'asc';
+        }
+
+        /**
          * Print column headers, accounting for hidden and sortable columns.
          *
@@ -1023 +1055 @@
                 $current_url = remove_query_arg( 'paged', $current_url );
 
-                if ( isset( $_GET['orderby'] ) )
-                        $current_orderby = $_GET['orderby'];
-                else
-                        $current_orderby = '';
-
-                if ( isset( $_GET['order'] ) && 'desc' === $_GET['order'] )
-                        $current_order = 'desc';
-                else
-                        $current_order = 'asc';
+                $current_orderby = $this->get_orderby();
+                $current_order = $this->get_order();
 
                 if ( ! empty( $columns['cb'] ) ) {