Changeset 34772

Timestamp:

10/02/2015 01:50:04 PM (9 years ago)

Author:

boonebgorges

Message:

Fix preg_match_all() syntax in PCRE benchmark test util.

In versions of PHP earlier than 5.4, the $matches parameter was required.
Excluding it here meant that PCRE benchmarking tests were erroring on older
versions of PHP without cleaning up the PCRE ini settings, causing various
problems on later tests.

Props miqrogroove, dd32, boonebgorges.

And to the cosmic forces that cause bugs like this. The best part of waking up
is diagnosing leakage between automated tests.

See #34121.

File:

• trunk/tests/phpunit/includes/utils.php (modified) (1 diff)

trunk/tests/phpunit/includes/utils.php

@@ -420 +420 @@
             break;
         case 'match_all':
-            preg_match_all( $pattern, $subject );
+            $matches = array();
+            preg_match_all( $pattern, $subject, $matches );
             break;
         }