Changeset 34773

Timestamp:

10/02/2015 01:50:12 PM (11 years ago)

Author:

boonebgorges

Message:

Improvements to PCRE benchmarking tests.

• Add test file accidentally omitted from [34761].
• Bail properly from benchmarker when a preg_last_error() is found.

Props miqrogroove.
See #34121.

Location:

trunk/tests/phpunit

Files:

• includes/utils.php (modified) (1 diff)
• tests/formatting/WpHtmlSplit.php (added)

trunk/tests/phpunit/includes/utils.php

@@ -434 +434 @@
         case PREG_RECURSION_LIMIT_ERROR:
             trigger_error('PCRE recursion limit encountered before backtrack limit.');
-            break;
+            return;
         case PREG_BAD_UTF8_ERROR:
             trigger_error('UTF-8 error during PCRE benchmark.');
-            break;
+            return;
         case PREG_INTERNAL_ERROR:
             trigger_error('Internal error during PCRE benchmark.');
-            break;
+            return;
         default:
-            trigger_error('Unexpected error during PCRE benchmark.');   
+            trigger_error('Unexpected error during PCRE benchmark.');
+            return;
         }
     }