Changeset 34780 for trunk/src/wp-includes/class-wp-widget.php

Timestamp:

10/02/2015 08:23:54 PM (11 years ago)

Author:

johnbillion

Message:

Introduce support for array format field names in WP_Widget::get_field_name() and WP_Widget::get_field_id().

Fixes #12133
Props ch1902, welcher

File:

• trunk/src/wp-includes/class-wp-widget.php (modified) (3 diffs)

trunk/src/wp-includes/class-wp-widget.php

@@ -178 +178 @@
          * This function should be used in form() methods to create name attributes for fields to be saved by update()
          *
+         * @since 4.4.0 Array format field names are now accepted.
+         *
          * @param string $field_name Field name
          * @return string Name attribute for $field_name
          */
         public function get_field_name($field_name) {
-                return 'widget-' . $this->id_base . '[' . $this->number . '][' . $field_name . ']';
+                if ( false === $pos = strpos( $field_name, '[' ) ) {
+                        return 'widget-' . $this->id_base . '[' . $this->number . '][' . $field_name . ']';
+                } else {
+                        return 'widget-' . $this->id_base . '[' . $this->number . '][' . substr_replace( $field_name, '][', $pos, strlen( '[' ) );
+                }
         }
 
@@ -191 +197 @@
          * for fields to be saved by {@see WP_Widget::update()}.
          *
+         * @since 4.4.0 Array format field IDs are now accepted.
+         *
          * @since 2.8.0
          * @access public
@@ -198 +206 @@
          */
         public function get_field_id( $field_name ) {
-                return 'widget-' . $this->id_base . '-' . $this->number . '-' . $field_name;
+                return 'widget-' . $this->id_base . '-' . $this->number . '-' . trim( str_replace( array( '[]', '[', ']' ), array( '', '-', '' ), $field_name ), '-' );
         }