Changeset 34789

Timestamp:

10/03/2015 12:19:17 AM (9 years ago)

Author:

westonruter

Message:

Customize: Fix nav_menu_item CSS classes array being incorrectly presented in input field as comma-delimited list.

Instead of using Array.toString() to serialize an array with comma delimiters, explicitly join the array using spaces instead. Also ensure that xfn is handled properly if it ever gets stored as an array.

Cherry-picks [34788].

Props tyxla, westonruter.
Fixes #34111 for 4.3.

Location:

branches/4.3

Files:

• . (modified) (1 prop)
• src/wp-admin/js/customize-nav-menus.js (modified) (1 diff)

branches/4.3/src/wp-admin/js/customize-nav-menus.js

@@ -1133 +1133 @@
                 });
                 if ( settingValue ) {
-                    element.set( settingValue[ property ] );
+                    if ( ( property === 'classes' || property === 'xfn' ) && _.isArray( settingValue[ property ] ) ) {
+                        element.set( settingValue[ property ].join( ' ' ) );
+                    } else {
+                        element.set( settingValue[ property ] );
+                    }
                 }
             });