Changeset 34802 for trunk/tests/phpunit/tests/admin/includesPost.php

Timestamp:

10/03/2015 05:14:12 PM (11 years ago)

Author:

DrewAPicture

Message:

Tests: Introduce WP_UnitTestCase::reset_permalinks(), an attempt to DRY up logic for resetting and restoring default permalinks on setUp() and tearDown().

See #33968.

File:

• trunk/tests/phpunit/tests/admin/includesPost.php (modified) (16 diffs)

trunk/tests/phpunit/tests/admin/includesPost.php

@@ -254 +254 @@
                 global $wp_rewrite;
 
-                $old_permalink_structure = get_option( 'permalink_structure' );
                 $permalink_structure = '%postname%';
                 $wp_rewrite->set_permalink_structure( "/$permalink_structure/" );
@@ -266 +265 @@
 
                 $this->assertSame( $expected, $found[0] );
-
-                $wp_rewrite->set_permalink_structure( $old_permalink_structure );
-                flush_rewrite_rules();
         }
 
@@ -276 +272 @@
          */
         public function test_get_sample_permalink_html_should_use_default_permalink_for_view_post_link_when_pretty_permalinks_are_disabled() {
-                global $wp_rewrite;
-                $old_permalink_structure = get_option( 'permalink_structure' );
-                $wp_rewrite->set_permalink_structure( '' );
-                flush_rewrite_rules();
-
                 wp_set_current_user( $this->factory->user->create( array( 'role' => 'administrator' ) ) );
 
@@ -288 +279 @@
                 $found = get_sample_permalink_html( $p );
                 $this->assertContains( 'href="' . get_option( 'home' ) . '/?p=' . $p . '"', $found );
-
-                $wp_rewrite->set_permalink_structure( $old_permalink_structure );
-                flush_rewrite_rules();
         }
 
@@ -299 +287 @@
         public function test_get_sample_permalink_html_should_use_pretty_permalink_for_view_post_link_when_pretty_permalinks_are_enabled() {
                 global $wp_rewrite;
-                $old_permalink_structure = get_option( 'permalink_structure' );
                 $permalink_structure = '%postname%';
                 $wp_rewrite->set_permalink_structure( "/$permalink_structure/" );
@@ -312 +299 @@
                 $post = get_post( $p );
                 $this->assertContains( 'href="' . get_option( 'home' ) . "/" . $post->post_name . '/"', $found );
-
-                $wp_rewrite->set_permalink_structure( $old_permalink_structure );
-                flush_rewrite_rules();
         }
 
@@ -323 +307 @@
         public function test_get_sample_permalink_html_should_use_correct_permalink_for_view_post_link_when_changing_slug() {
                 global $wp_rewrite;
-                $old_permalink_structure = get_option( 'permalink_structure' );
                 $permalink_structure = '%postname%';
                 $wp_rewrite->set_permalink_structure( "/$permalink_structure/" );
@@ -358 +341 @@
 
                 $this->assertContains( 'href="' . esc_url( $preview_link ) . '"', $found, $message );
-
-                $wp_rewrite->set_permalink_structure( $old_permalink_structure );
-                flush_rewrite_rules();
         }
 
@@ -378 +358 @@
                 $found = get_sample_permalink( $p );
                 $this->assertEquals( '2015-2', $found[1] );
-
-                $wp_rewrite->set_permalink_structure( '' );
-                flush_rewrite_rules();
         }
 
@@ -398 +375 @@
                 $found = get_sample_permalink( $p );
                 $this->assertEquals( '2015', $found[1] );
-
-                $wp_rewrite->set_permalink_structure( '' );
-                flush_rewrite_rules();
         }
 
@@ -418 +392 @@
                 $found = get_sample_permalink( $p );
                 $this->assertEquals( '11-2', $found[1] );
-
-                $wp_rewrite->set_permalink_structure( '' );
-                flush_rewrite_rules();
         }
 
@@ -438 +409 @@
                 $found = get_sample_permalink( $p );
                 $this->assertEquals( '13', $found[1] );
-
-                $wp_rewrite->set_permalink_structure( '' );
-                flush_rewrite_rules();
         }
 
@@ -458 +426 @@
                 $found = get_sample_permalink( $p );
                 $this->assertEquals( '30-2', $found[1] );
-
-                $wp_rewrite->set_permalink_structure( '' );
-                flush_rewrite_rules();
         }
 
@@ -482 +447 @@
                 $found = get_sample_permalink( $p );
                 $this->assertEquals( '30-3', $found[1] );
-
-                $wp_rewrite->set_permalink_structure( '' );
-                flush_rewrite_rules();
         }
 
@@ -502 +464 @@
                 $found = get_sample_permalink( $p );
                 $this->assertEquals( '32', $found[1] );
-
-                $wp_rewrite->set_permalink_structure( '' );
-                flush_rewrite_rules();
         }
 
@@ -522 +481 @@
                 $found = get_sample_permalink( $p );
                 $this->assertEquals( '30', $found[1] );
-
-                $wp_rewrite->set_permalink_structure( '' );
-                flush_rewrite_rules();
         }