WordPress.org

Make WordPress Core


Ignore:
Timestamp:
10/03/2015 08:24:09 PM (5 years ago)
Author:
boonebgorges
Message:

When creating terms, avoid false dupe checks due to accented characters.

wp_insert_term() doesn't allow the creation of a term when the term name
is the same as another term in the same hierarchy level of the same taxonomy.
Previously, this duplicate check used get_term_by( 'name' ), which uses the
database collation to determine sameness. But common collations do not
distinguish between accented and non-accented versions of a character. As a
result, it was impossible to create a term 'Foo' if a sibling term with an
accented character existed.

We address this problem by using get_terms() to do the duplicate check. This
query returns all potentially matching terms. We then do a stricter check
for equivalence in PHP, before determining whether one of the matches is
indeed a duplicate.

Props boonebgorges, tyxla, geza.miklo, mehulkaklotar.
Fixes #33864.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/taxonomy-functions.php

    r34787 r34809  
    25172517     * unless a unique slug has been explicitly provided.
    25182518     */
    2519     if ( $name_match = get_term_by( 'name', $name, $taxonomy ) ) {
     2519    $name_matches = get_terms( $taxonomy, array(
     2520        'name' => $name,
     2521        'hide_empty' => false,
     2522    ) );
     2523
     2524    /*
     2525     * The `name` match in `get_terms()` doesn't differentiate accented characters,
     2526     * so we do a stricter comparison here.
     2527     */
     2528    $name_match = null;
     2529    if ( $name_matches ) {
     2530        foreach ( $name_matches as $_match ) {
     2531            if ( strtolower( $name ) === strtolower( $_match->name ) ) {
     2532                $name_match = $_match;
     2533                break;
     2534            }
     2535        }
     2536    }
     2537
     2538    if ( $name_match ) {
    25202539        $slug_match = get_term_by( 'slug', $slug, $taxonomy );
    25212540        if ( ! $slug_provided || $name_match->slug === $slug || $slug_match ) {
Note: See TracChangeset for help on using the changeset viewer.