WordPress.org

Make WordPress Core


Ignore:
Timestamp:
10/03/2015 08:24:09 PM (5 years ago)
Author:
boonebgorges
Message:

When creating terms, avoid false dupe checks due to accented characters.

wp_insert_term() doesn't allow the creation of a term when the term name
is the same as another term in the same hierarchy level of the same taxonomy.
Previously, this duplicate check used get_term_by( 'name' ), which uses the
database collation to determine sameness. But common collations do not
distinguish between accented and non-accented versions of a character. As a
result, it was impossible to create a term 'Foo' if a sibling term with an
accented character existed.

We address this problem by using get_terms() to do the duplicate check. This
query returns all potentially matching terms. We then do a stricter check
for equivalence in PHP, before determining whether one of the matches is
indeed a duplicate.

Props boonebgorges, tyxla, geza.miklo, mehulkaklotar.
Fixes #33864.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/term/wpInsertTerm.php

    r34720 r34809  
    629629    }
    630630
     631    /**
     632     * @ticket 33864
     633     */
     634    public function test_wp_insert_term_with_and_without_accents() {
     635        register_taxonomy( 'wptests_tax', 'post' );
     636
     637        $t1 = $this->factory->term->create( array(
     638            'name' => 'Foó',
     639            'taxonomy' => 'wptests_tax',
     640        ) );
     641        $t2 = $this->factory->term->create( array(
     642            'name' => 'Foo',
     643            'taxonomy' => 'wptests_tax',
     644        ) );
     645
     646        $this->assertInternalType( 'int', $t1 );
     647        $this->assertInternalType( 'int', $t2 );
     648        $this->assertNotEquals( $t1, $t2 );
     649
     650        $term_2 = get_term( $t2, 'wptests_tax' );
     651        $this->assertSame( $t2, $term_2->term_id );
     652        $this->assertSame( 'Foo', $term_2->name );
     653
     654    }
     655
    631656    /** Helpers **********************************************************/
    632657
Note: See TracChangeset for help on using the changeset viewer.