Changeset 34828 for trunk/tests/phpunit/tests/option/updateOption.php

Timestamp:

10/05/2015 03:05:26 PM (10 years ago)

Author:

boonebgorges

Message:

Use wp_installing() instead of WP_INSTALLING constant.

The WP_INSTALLING constant is a flag that WordPress sets in a number of
places, telling the system that options should be fetched directly from the
database instead of from the cache, that WP should not ping wordpress.org for
updates, that the normal "not installed" checks should be bypassed, and so on.

A constant is generally necessary for this purpose, because the flag is
typically set before the WP bootstrap, meaning that WP functions are not yet
available. However, it is possible - notably, during wpmu_create_blog() -
for the "installing" flag to be set after WP has already loaded. In these
cases, WP_INSTALLING would be set for the remainder of the process, since
there's no way to change a constant once it's defined. This, in turn, polluted
later function calls that ought to have been outside the scope of site
creation, particularly the non-caching of option data. The problem was
particularly evident in the case of the automated tests, where WP_INSTALLING
was set the first time a site was created, and remained set for the rest of the
suite.

The new wp_installing() function allows developers to fetch the current
installation status (when called without any arguments) or to set the
installation status (when called with a boolean true or false). Use of
the WP_INSTALLING constant is still supported; wp_installing() will default
to true if the constant is defined during the bootstrap.

Props boonebgorges, jeremyfelt.
See #31130.

File:

• trunk/tests/phpunit/tests/option/updateOption.php (modified) (7 diffs)

trunk/tests/phpunit/tests/option/updateOption.php

@@ -21 +21 @@
      */
     public function test_should_set_autoload_yes_for_nonexistent_option_when_autoload_param_is_missing() {
-        if ( is_multisite() ) {
-            $this->markTestSkipped( 'Not testable in MS: wpmu_create_blog() defines WP_INSTALLING, which causes cache misses.' );
-        }
-
         global $wpdb;
         $this->flush_cache();
@@ -45 +41 @@
      */
     public function test_should_set_autoload_yes_for_nonexistent_option_when_autoload_param_is_yes() {
-        if ( is_multisite() ) {
-            $this->markTestSkipped( 'Not testable in MS: wpmu_create_blog() defines WP_INSTALLING, which causes cache misses.' );
-        }
-
         global $wpdb;
         $this->flush_cache();
@@ -69 +61 @@
      */
     public function test_should_set_autoload_no_for_nonexistent_option_when_autoload_param_is_no() {
-        if ( is_multisite() ) {
-            $this->markTestSkipped( 'Not testable in MS: wpmu_create_blog() defines WP_INSTALLING, which causes cache misses.' );
-        }
-
         global $wpdb;
         $this->flush_cache();
@@ -94 +82 @@
      */
     public function test_should_set_autoload_no_for_nonexistent_option_when_autoload_param_is_false() {
-        if ( is_multisite() ) {
-            $this->markTestSkipped( 'Not testable in MS: wpmu_create_blog() defines WP_INSTALLING, which causes cache misses.' );
-        }
-
         global $wpdb;
         $this->flush_cache();
@@ -119 +103 @@
      */
     public function test_autoload_should_be_updated_for_existing_option_when_value_is_changed() {
-        if ( is_multisite() ) {
-            $this->markTestSkipped( 'Not testable in MS: wpmu_create_blog() defines WP_INSTALLING, which causes cache misses.' );
-        }
-
         global $wpdb;
         add_option( 'foo', 'bar', '', 'no' );
@@ -144 +124 @@
      */
     public function test_autoload_should_not_be_updated_for_existing_option_when_value_is_unchanged() {
-        if ( is_multisite() ) {
-            $this->markTestSkipped( 'Not testable in MS: wpmu_create_blog() defines WP_INSTALLING, which causes cache misses.' );
-        }
-
         global $wpdb;
         add_option( 'foo', 'bar', '', 'yes' );
@@ -170 +146 @@
      */
     public function test_autoload_should_not_be_updated_for_existing_option_when_value_is_changed_but_no_value_of_autoload_is_provided() {
-        if ( is_multisite() ) {
-            $this->markTestSkipped( 'Not testable in MS: wpmu_create_blog() defines WP_INSTALLING, which causes cache misses.' );
-        }
-
         global $wpdb;
         add_option( 'foo', 'bar', '', 'yes' );