Changeset 34838 for trunk/src/wp-includes/class-wp-customize-setting.php

Timestamp:

10/05/2015 09:57:32 PM (11 years ago)

Author:

westonruter

Message:

Customizer: Ensure WP_Customize_Setting::update() returns boolean value.

Adds unit tests for WP_Customize_Setting::save() (and WP_Customize_Setting::update()), along with the actions customize_update_{$type}, and customize_save_{$id_base} which they trigger.

Fixes #34140.

File:

• trunk/src/wp-includes/class-wp-customize-setting.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-customize-setting.php

@@ -305 +305 @@
          *
          * @param mixed $value The value to update.
-         * @return mixed The result of saving the value.
+         * @return bool The result of saving the value.
          */
         protected function update( $value ) {
-                switch( $this->type ) {
+                switch ( $this->type ) {
                         case 'theme_mod' :
-                                return $this->_update_theme_mod( $value );
+                                $this->_update_theme_mod( $value );
+                                return true;
 
                         case 'option' :
@@ -328 +329 @@
                                  * @param WP_Customize_Setting $this  WP_Customize_Setting instance.
                                  */
-                                return do_action( 'customize_update_' . $this->type, $value, $this );
+                                do_action( "customize_update_{$this->type}", $value, $this );
+
+                                return has_action( "customize_update_{$this->type}" );
                 }
         }