Changeset 34848

Timestamp:

10/06/2015 03:36:18 AM (9 years ago)

Author:

jorbin

Message:

HTTP timeouts should cause some tests to be skipped, not failed

A number of the HTTP external tests can inconstantly fail. As the HTTP API is one that doesn't change often, this failure creates noise. With the goal of increasing the signal from the unit tests, these tests are now skipped if they timeout. A notice is added when running the external http tests so that the developer knows what skipped tests may mean here.

See #33968

Location:

trunk/tests/phpunit

Files:

• includes/bootstrap.php (modified) (1 diff)
• tests/http/base.php (modified) (4 diffs)

trunk/tests/phpunit/includes/bootstrap.php

@@ -165 +165 @@
             echo sprintf( 'Not running %1$s tests. To execute these, use --group %1$s.', $group_name ) . PHP_EOL;
         }
+
+        if ( ! isset( $skipped_groups['external-http'] ) ){
+            echo PHP_EOL;
+            echo 'External HTTP skipped tests can be caused by timeouts.' . PHP_EOL;
+            echo 'If this changeset inclues changes to HTTP, make sure there are no timeouts.' . PHP_EOL;
+            echo PHP_EOL;
+        }
     }
 }

trunk/tests/phpunit/tests/http/base.php

@@ -18 +18 @@
     protected $http_request_args;
 
+    /**
+     * Mark test as skipped if the HTTP request times out
+     */
+    function skipTestOnTimeout( $response ) {
+        if( ! is_wp_error( $response ) ){
+            return;
+        }
+        if ( 'connect() timed out!' === $response->get_error_message() ){
+            $this->markTestSkipped( 'HTTP timeout' );
+        }
+
+        if ( 0 === strpos( $response->get_error_message(), 'Operation timed out after' ) ){
+            $this->markTestSkipped( 'HTTP timeout' );
+        }
+
+        if ( 'stream_socket_client(): unable to connect to tcp://s.w.org:80 (Connection timed out)' === $response->get_error_message() ){
+            $this->markTestSkipped( 'HTTP timeout' );
+        }
+
+    }
+
     function setUp() {
 
@@ -199 +220 @@
         }
 
+        $this->skipTestOnTimeout ($res );
+
         $this->assertNotWPError( $res );
         $this->assertEquals( '', $res['body'] ); // The body should be empty.
@@ -220 +243 @@
         }
 
+        $this->skipTestOnTimeout ($res );
+
         $this->assertNotWPError( $res );
         $this->assertEquals( $size, $filesize ); // Check that the file is written to disk correctly without any extra characters
@@ -235 +260 @@
 
         $res = wp_remote_request( $url, array( 'timeout' => 30, 'limit_response_size' => $size ) );
+
+        $this->skipTestOnTimeout ($res );
 
         $this->assertNotWPError( $res );