Make WordPress Core


Ignore:
Timestamp:
10/06/2015 03:36:18 AM (8 years ago)
Author:
jorbin
Message:

HTTP timeouts should cause some tests to be skipped, not failed

A number of the HTTP external tests can inconstantly fail. As the HTTP API is one that doesn't change often, this failure creates noise. With the goal of increasing the signal from the unit tests, these tests are now skipped if they timeout. A notice is added when running the external http tests so that the developer knows what skipped tests may mean here.

See #33968

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/includes/bootstrap.php

    r34172 r34848  
    165165            echo sprintf( 'Not running %1$s tests. To execute these, use --group %1$s.', $group_name ) . PHP_EOL;
    166166        }
     167
     168        if ( ! isset( $skipped_groups['external-http'] ) ){
     169            echo PHP_EOL;
     170            echo 'External HTTP skipped tests can be caused by timeouts.' . PHP_EOL;
     171            echo 'If this changeset inclues changes to HTTP, make sure there are no timeouts.' . PHP_EOL;
     172            echo PHP_EOL;
     173        }
    167174    }
    168175}
Note: See TracChangeset for help on using the changeset viewer.