Changeset 34856 for trunk/src/wp-includes/user-functions.php

Timestamp:

10/06/2015 05:34:47 AM (10 years ago)

Author:

DrewAPicture

Message:

Users: Empty sanitized usernames should be considered invalid when passed through validate_username().

Adds tests.

Props gwinhlopez for the initial patch.
Props mordauk, chriscct7.
Fixes #24618.

File:

• trunk/src/wp-includes/user-functions.php (modified) (2 diffs)

trunk/src/wp-includes/user-functions.php

@@ -1177 +1177 @@
  *
  * @since 2.0.1
+ * @since 4.4.0 Empty sanitized usernames are now considered invalid
  *
  * @param string $username Username.
@@ -1183 +1184 @@
 function validate_username( $username ) {
     $sanitized = sanitize_user( $username, true );
-    $valid = ( $sanitized == $username );
+    $valid = ( $sanitized == $username && ! empty( $sanitized ) );
+
     /**
      * Filter whether the provided username is valid or not.