Changeset 34879 for trunk/tests/phpunit/tests/ajax/DeleteComment.php

Timestamp:

10/06/2015 07:55:56 PM (9 years ago)

Author:

jorbin

Message:

Add message with status info to temperamental assertion.

The ajax delete comment tests are intermittently failing. Many of the assertions make it hard to tell why they are failing. This adds a message to one of those assertions that contains some info on what is being asserted with the goal that it helps developers understand why the failure is failing.

See #33968

File:

• trunk/tests/phpunit/tests/ajax/DeleteComment.php (modified) (1 diff)

trunk/tests/phpunit/tests/ajax/DeleteComment.php

@@ -102 +102 @@
 
         // Check for either possible total
-        $this->assertTrue( in_array( (int) $xml->response[0]->comment[0]->supplemental[0]->total[0] , array( $total, $recalc_total ) ) );
+        $message = sprintf( 'returned value: %1$d $total: %2$d  $recalc_total: %3$d', (int)  $xml->response[0]->comment[0]->supplemental[0]->total[0], $total, $recalc_total );
+        $this->assertTrue( in_array( (int) $xml->response[0]->comment[0]->supplemental[0]->total[0] , array( $total, $recalc_total ) ), $message );
     }