Changeset 34901

Timestamp:

10/07/2015 07:20:45 AM (11 years ago)

Author:

jeremyfelt

Message:

Tests: Improve tests for upload_is_user_over_quota().

• Move all tests to a new 'multisite/uploadIsUserOverQuota.php'
• Use get_space_allowed and pre_get_space_used filters to help avoid test pollution.

See #34037.

Location:

trunk/tests/phpunit/tests/multisite

Files:

• site.php (modified) (1 diff)
• uploadIsUserOverQuota.php (added)

trunk/tests/phpunit/tests/multisite/site.php

@@ -907 +907 @@
 
         /**
-         * Provide a hardcoded amount for space used when testing upload quota,
-         * allowed space, and available space.
-         *
-         * @return int
-         */
-        function _filter_space_used() {
-                return 300;
-        }
-
-        function test_upload_is_user_over_quota_default() {
-                $this->assertFalse( upload_is_user_over_quota( false ) );
-        }
-
-        function test_upload_is_user_over_quota_check_enabled() {
-                update_site_option( 'upload_space_check_disabled', false );
-                // will be set to ''
-                $this->assertEmpty( get_site_option( 'upload_space_check_disabled' ) );
-
-                $this->assertEquals(
-                        upload_is_user_over_quota( false ),
-                        self::$space_used > self::$space_allowed
-                );
-        }
-
-        /**
-         * When the upload space check is disabled, using more than the available
-         * quota is allowed.
-         */
-        function test_upload_is_user_over_check_disabled() {
-                update_site_option( 'upload_space_check_disabled', true );
-                update_site_option( 'blog_upload_space', 100 );
-                add_filter( 'pre_get_space_used', array( $this, '_filter_space_used' ) );
-                $quota = upload_is_user_over_quota( false );
-                remove_filter( 'pre_get_space_used', array( $this, '_filter_space_used' ) );
-
-                $this->assertFalse( $quota );
-        }
-
-        /**
-         * If 0 is set for `blog_upload_space`, a fallback of 100 is used.
-         */
-        function test_upload_is_user_over_quota_upload_space_0() {
-                update_site_option( 'upload_space_check_disabled', false );
-                update_site_option( 'blog_upload_space', 0 );
-
-                $this->assertEquals(
-                        upload_is_user_over_quota( false ),
-                        self::$space_used > self::$space_allowed
-                );
-        }
-
-        /**
-         * Filter the space space used as 300 to trigger a true upload quota
-         * without requiring actual files.
-         */
-        function test_upload_is_user_over_quota_upload_space_0_filter_space_used() {
-                update_site_option( 'upload_space_check_disabled', false );
-                update_site_option( 'blog_upload_space', 0 );
-                add_filter( 'pre_get_space_used', array( $this, '_filter_space_used' ) );
-                $quota = upload_is_user_over_quota( false );
-                remove_filter( 'pre_get_space_used', array( $this, '_filter_space_used' ) );
-
-                $this->assertTrue( $quota );
-        }
-
-        function test_upload_is_user_over_quota_upload_space_200() {
-                update_site_option( 'upload_space_check_disabled', false );
-                update_site_option( 'blog_upload_space', 200 );
-                $this->assertEquals(
-                        upload_is_user_over_quota( false ),
-                        self::$space_used > 200
-                );
-        }
-
-        function test_upload_is_user_over_quota_upload_space_200_filter_space_used() {
-                update_site_option( 'upload_space_check_disabled', false );
-                update_site_option( 'blog_upload_space', 200 );
-                add_filter( 'pre_get_space_used', array( $this, '_filter_space_used' ) );
-                $quota = upload_is_user_over_quota( false );
-                remove_filter( 'pre_get_space_used', array( $this, '_filter_space_used' ) );
-
-                $this->assertTrue( $quota );
-        }
-
-        /**
-         * If the space used is exactly the same as the available quota, an over
-         * quota response is not expected.
-         *
-         * @group woo
-         */
-        function test_upload_is_user_over_quota_upload_space_exact() {
-                update_site_option( 'upload_space_check_disabled', false );
-                update_site_option( 'blog_upload_space', 300 );
-                add_filter( 'pre_get_space_used', array( $this, '_filter_space_used' ) );
-                $quota = upload_is_user_over_quota( false );
-                $used = get_space_used();
-                remove_filter( 'pre_get_space_used', array( $this, '_filter_space_used' ) );
-
-                $this->assertEquals(
-                        $quota,
-                        $used > 300
-                );
-        }
-
-        function test_upload_is_user_over_quota_upload_space_negative() {
-                update_site_option( 'upload_space_check_disabled', false );
-                update_site_option( 'blog_upload_space', -1 );
-                $this->assertTrue( upload_is_user_over_quota( false ) );
-        }
-
-        /**
          * Test the primary purpose of get_blog_post(), to retrieve a post from
          * another site on the network.