Changeset 34919 for trunk/src/wp-includes/user-functions.php

Timestamp:

10/07/2015 10:41:07 PM (10 years ago)

Author:

boonebgorges

Message:

Handle WP_User objects properly in update_user_caches().

We should not be storing the WP_User object in the cache, as it may contain
usermeta and other data that's cache elsewhere.

Props dd32.
See #24635.

File:

• trunk/src/wp-includes/user-functions.php (modified) (1 diff)

trunk/src/wp-includes/user-functions.php

@@ -1103 +1103 @@
  * @since 3.0.0
  *
- * @param object $user User object to be cached
- */
-function update_user_caches($user) {
+ * @param object|WP_User $user User object to be cached
+ * @return bool|null Returns false on failure.
+ */
+function update_user_caches( $user ) {
+    if ( $user instanceof WP_User ) {
+        if ( ! $user->exists() ) {
+            return false;
+        }
+
+        $user = $user->data;
+    }
+
     wp_cache_add($user->ID, $user, 'users');
     wp_cache_add($user->user_login, $user->ID, 'userlogins');