Changeset 34977

Timestamp:

10/09/2015 01:26:46 AM (11 years ago)

Author:

azaozz

Message:

JS: in event callbacks replace the very outdated return false with preventDefault().

Props adamsilverstein.
Fixes #18590.

Location:

trunk/src/wp-admin/js

Files:

• dashboard.js (modified) (2 diffs)
• edit-comments.js (modified) (3 diffs)
• gallery.js (modified) (1 diff)
• inline-edit-post.js (modified) (1 diff)
• plugin-install.js (modified) (2 diffs)
• post.js (modified) (8 diffs)
• postbox.js (modified) (1 diff)

trunk/src/wp-admin/js/dashboard.js

@@ -68 +68 @@
                 $( '#quick-press .submit input[type="submit"], #quick-press .submit input[type="reset"]' ).prop( 'disabled' , false );
 
-                t = $('#quick-press').submit( function() {
+                t = $('#quick-press').submit( function( e ) {
+                        e.preventDefault();
                         $('#dashboard_quick_press #publishing-action .spinner').show();
                         $('#quick-press .submit input[type="submit"], #quick-press .submit input[type="reset"]').prop('disabled', true);
@@ -88 +89 @@
                                 }, 1000);
                         }
-
-                        return false;
                 } );
 

trunk/src/wp-admin/js/edit-comments.js

@@ -285 +285 @@
                         $('.avatar', el).first().clone().prependTo('#undo-' + id + ' .' + action + '-undo-inside');
 
-                        a.click(function(){
+                        a.click(function( e ){
+                                e.preventDefault();
                                 list.wpList.del(this);
                                 $('#undo-' + id).css( {backgroundColor:'#ceb'} ).fadeOut(350, function(){
@@ -291 +292 @@
                                         $('#comment-' + id).css('backgroundColor', '').fadeIn(300, function(){ $(this).show(); });
                                 });
-                                return false;
                         });
                 }
@@ -855 +855 @@
         setCommentsList();
         commentReply.init();
-        $(document).delegate('span.delete a.delete', 'click', function(){return false;});
+
+        $(document).on( 'click', 'span.delete a.delete', function( e ) {
+                e.preventDefault();
+        });
 
         if ( typeof $.table_hotkeys != 'undefined' ) {

trunk/src/wp-admin/js/gallery.js

@@ -39 +39 @@
         };
 
-        $('#asc').click( function() {
+        $('#asc').click( function( e ) {
+                e.preventDefault();
                 desc = false;
                 sortIt();
-                return false;
-        });
-        $('#desc').click( function() {
+        });
+        $('#desc').click( function( e ) {
+                e.preventDefault();
                 desc = true;
                 sortIt();
-                return false;
-        });
-        $('#clear').click( function() {
+        });
+        $('#clear').click( function( e ) {
+                e.preventDefault();
                 clearAll(1);
-                return false;
-        });
-        $('#showall').click( function() {
+        });
+        $('#showall').click( function( e ) {
+                e.preventDefault();
                 $('#sort-buttons span a').toggle();
                 $('a.describe-toggle-on').hide();
                 $('a.describe-toggle-off, table.slidetoggle').show();
                 $('img.pinkynail').toggle(false);
-                return false;
-        });
-        $('#hideall').click( function() {
+        });
+        $('#hideall').click( function( e ) {
+                e.preventDefault();
                 $('#sort-buttons span a').toggle();
                 $('a.describe-toggle-on').show();
                 $('a.describe-toggle-off, table.slidetoggle').hide();
                 $('img.pinkynail').toggle(true);
-                return false;
         });
 

trunk/src/wp-admin/js/inline-edit-post.js

@@ -49 +49 @@
 
                 // add events
-                $('#the-list').on('click', 'a.editinline', function(){
+                $('#the-list').on( 'click', 'a.editinline', function( e ) {
+                        e.preventDefault();
                         inlineEditPost.edit(this);
-                        return false;
                 });
 

trunk/src/wp-admin/js/plugin-install.js

@@ -39 +39 @@
         });
 
-        $( '.plugin-card, .plugins .plugin-version-author-uri' ).on( 'click', 'a.thickbox', function() {
+        $( '.plugin-card, .plugins .plugin-version-author-uri' ).on( 'click', 'a.thickbox', function( e ) {
+                e.preventDefault();
                 tb_click.call(this);
 
@@ -46 +47 @@
                 $('#TB_iframeContent').attr( 'title', plugininstallL10n.plugin_information + ' ' + $(this).data( 'title' ) );
                 $('#TB_closeWindowButton').focus();
-
-                return false;
         });
 

trunk/src/wp-admin/js/post.js

@@ -433 +433 @@
 
                 // TODO: move to jQuery 1.3+, support for multiple hierarchical taxonomies, see wp-lists.js
-                $('a', '#' + taxonomy + '-tabs').click( function(){
+                $('a', '#' + taxonomy + '-tabs').click( function( e ) {
+                        e.preventDefault();
                         var t = $(this).attr('href');
                         $(this).parent().addClass('tabs').siblings('li').removeClass('tabs');
@@ -442 +443 @@
                         else
                                 setUserSetting( settingName, 'pop' );
-                        return false;
                 });
 
@@ -484 +484 @@
                 });
 
-                $('#' + taxonomy + '-add-toggle').click( function() {
+                $('#' + taxonomy + '-add-toggle').click( function( e ) {
+                        e.preventDefault();
                         $('#' + taxonomy + '-adder').toggleClass( 'wp-hidden-children' );
                         $('a[href="#' + taxonomy + '-all"]', '#' + taxonomy + '-tabs').click();
                         $('#new'+taxonomy).focus();
-                        return false;
                 });
 
@@ -609 +609 @@
                 };
 
-                $( '#visibility .edit-visibility').click( function () {
+                $( '#visibility .edit-visibility').click( function( e ) {
+                        e.preventDefault();
                         if ( $postVisibilitySelect.is(':hidden') ) {
                                 updateVisibility();
@@ -617 +618 @@
                                 $(this).hide();
                         }
-                        return false;
                 });
 
@@ -743 +743 @@
 
                 buttons.html('<button type="button" class="save button button-small">'+postL10n.ok+'</button> <a class="cancel" href="#">'+postL10n.cancel+'</a>');
-                buttons.children('.save').click(function() {
+                buttons.children('.save').click( function( e ) {
                         var new_slug = e.children('input').val();
+                        e.preventDefault();
                         if ( new_slug == $('#editable-post-name-full').text() ) {
                                 buttons.children('.cancel').click();
-                                return false;
+                                return;
                         }
                         $.post(ajaxurl, {
@@ -769 +770 @@
                                 $( '.edit-slug' ).focus();
                         });
-                        return false;
-                });
-
-                buttons.children('.cancel').click(function() {
+                });
+
+                buttons.children('.cancel').click( function( e ) {
+                        e.preventDefault();
                         $('#view-post-btn').show();
                         e.html(revert_e);
@@ -779 +780 @@
                         real_slug.val(revert_slug);
                         $( '.edit-slug' ).focus();
-                        return false;
                 });
 

trunk/src/wp-admin/js/postbox.js

@@ -57 +57 @@
                         });
 
-                        $( '.postbox a.dismiss' ).bind( 'click.postboxes', function() {
+                        $( '.postbox a.dismiss' ).on( 'click.postboxes', function( e ) {
                                 var hide_id = $(this).parents('.postbox').attr('id') + '-hide';
+                                e.preventDefault();
                                 $( '#' + hide_id ).prop('checked', false).triggerHandler('click');
-                                return false;
                         });