Changeset 34984

Timestamp:

10/09/2015 04:46:00 AM (9 years ago)

Author:

SergeyBiryukov

Message:

Media: Return early from media_sideload_image() if $file didn't match the pattern for images.

Props MikeHansenMe, serpent7776.
Fixes #32755.

File:

• trunk/src/wp-admin/includes/media.php (modified) (1 diff)

trunk/src/wp-admin/includes/media.php

@@ -848 +848 @@
         // Set variables for storage, fix file filename for query strings.
         preg_match( '/[^\?]+\.(jpe?g|jpe|gif|png)\b/i', $file, $matches );
+        if ( ! $matches ) {
+            return new WP_Error( 'image_sideload_failed', __( 'Invalid image URL' ) );
+        }
+
         $file_array = array();
         $file_array['name'] = basename( $matches[0] );