Changeset 35015

Timestamp:

10/10/2015 04:33:33 PM (9 years ago)

Author:

afercia

Message:

Accessibility: bump headings one level up on the Appearance > Widgets screen for a better headings hierarchy.

Props mrahmadawais, afercia.
Fixes #33659.

Location:

trunk/src/wp-admin

Files:

• css/customize-widgets.css (modified) (2 diffs)
• css/widgets.css (modified) (4 diffs)
• includes/widgets.php (modified) (2 diffs)
• js/widgets.js (modified) (2 diffs)
• widgets.php (modified) (2 diffs)

trunk/src/wp-admin/css/customize-widgets.css

@@ -420 +420 @@
 }
 
-#available-widgets .widget-title h4 {
+#customize-controls .widget-title h3 {
+    font-size: 1em;
+}
+
+#available-widgets .widget-title h3 {
     padding: 0 0 5px;
     font-size: 14px;
@@ -622 +626 @@
         margin-bottom: 15px;
     }
-    .widget-title h4 {
+    .widget-title h3 {
         padding: 13px 15px;
     }

trunk/src/wp-admin/css/widgets.css

@@ -23 +23 @@
 }
 
+.widget-title h3,
 .widget-title h4 {
     margin: 0;
     padding: 15px;
+    font-size: 1em;
     line-height: 1;
     overflow: hidden;
@@ -101 +103 @@
 }
 
+.sidebar-name h2,
 .sidebar-name h3 {
     margin: 0;
@@ -143 +146 @@
 }
 
+div#widgets-left .sidebar-name h2,
 div#widgets-left .sidebar-name h3 {
     padding: 10px 0;
@@ -244 +248 @@
 }
 
+div#widgets-right .sidebar-name h2,
 div#widgets-right .sidebar-name h3 {
     padding: 15px 7px;

trunk/src/wp-admin/includes/widgets.php

@@ -82 +82 @@
         <div class="sidebar-name">
             <div class="sidebar-name-arrow"><br /></div>
-            <h3><?php echo esc_html( $sidebar_name ); ?> <span class="spinner"></span></h3>
+            <h2><?php echo esc_html( $sidebar_name ); ?> <span class="spinner"></span></h2>
         </div>
         <?php
@@ -227 +227 @@
         </a>
     </div>
-    <div class="widget-title"><h4><?php echo $widget_title ?><span class="in-widget-title"></span></h4></div>
+    <div class="widget-title"><h3><?php echo $widget_title; ?><span class="in-widget-title"></span></h3></div>
     </div>
 

trunk/src/wp-admin/js/widgets.js

@@ -298 +298 @@
                 if ( ui.draggable.hasClass('ui-sortable-helper') ) {
                     $('#removing-widget').show().children('span')
-                    .html( ui.draggable.find('div.widget-title').children('h4').html() );
+                    .html( ui.draggable.find( 'div.widget-title' ).children( 'h3' ).html() );
                 }
             },
@@ -311 +311 @@
         $( '#widgets-right .widgets-holder-wrap' ).each( function( index, element ) {
             var $element = $( element ),
-                name = $element.find( '.sidebar-name h3' ).text(),
+                name = $element.find( '.sidebar-name h2' ).text(),
                 id = $element.find( '.widgets-sortables' ).attr( 'id' ),
                 li = $('<li tabindex="0">').text( $.trim( name ) );

trunk/src/wp-admin/widgets.php

@@ -245 +245 @@
     <h1><?php echo esc_html( $title ); ?></h1>
     <div class="editwidget"<?php echo $width; ?>>
-    <h3><?php printf( __( 'Widget %s' ), $name ); ?></h3>
+    <h2><?php printf( __( 'Widget %s' ), $name ); ?></h2>
 
     <form action="widgets.php" method="post">
@@ -362 +362 @@
         <div class="sidebar-name">
             <div class="sidebar-name-arrow"><br /></div>
-            <h3><?php _e('Available Widgets'); ?> <span id="removing-widget"><?php _ex('Deactivate', 'removing-widget'); ?> <span></span></span></h3>
+            <h2><?php _e( 'Available Widgets' ); ?> <span id="removing-widget"><?php _ex( 'Deactivate', 'removing-widget' ); ?> <span></span></span></h2>
         </div>
         <div class="widget-holder">