Changeset 35023

Timestamp:

10/11/2015 05:09:33 PM (9 years ago)

Author:

DrewAPicture

Message:

Media: Remove logic for unnecessarily overloading the $content_width global when passing default dimensions used to display the post thumbnail image in the 'Featured Image' meta box.

Updates documentation for the $size parameter in admin_post_thumbnail_size filter doc.

See #28512.

File:

• trunk/src/wp-admin/includes/post.php (modified) (3 diffs)

trunk/src/wp-admin/includes/post.php

@@ -1395 +1395 @@
 
     if ( $thumbnail_id && get_post( $thumbnail_id ) ) {
-        $old_content_width = $content_width;
-        $content_width = 266;
-
-        $size = isset( $_wp_additional_image_sizes['post-thumbnail'] ) ? 'post-thumbnail' : array( $content_width, $content_width );
+        $size = isset( $_wp_additional_image_sizes['post-thumbnail'] ) ? 'post-thumbnail' : array( 266, 266 );
 
         /**
@@ -1410 +1407 @@
          * @since 4.4.0
          *
-         * @param string|array $size         Post thumbnail image size to display in the meta box. Accepts
-         *                                   any valid image size, or an array of height and width values.
-         *                                   If the 'post-thumbnail' size is set, default is 'post-thumbnail'.
-         *                                   Otherwise, default is an array with `$content_width` as the
-         *                                   height and width values.
+         * @param string|array $size         Post thumbnail image size to display in the meta box. Accepts any valid
+         *                                   image size, or an array of height and width values in pixels. If the
+         *                                   'post-thumbnail' size is set, default is 'post-thumbnail'. Otherwise,
+         *                                   default is an array with 266 as both the height and width values.
          * @param int          $thumbnail_id Post thumbnail attachment ID.
          * @param WP_Post      $post         The post object associated with the thumbnail.
@@ -1431 +1427 @@
             $content .= '<p class="hide-if-no-js"><a href="#" id="remove-post-thumbnail" onclick="WPRemoveThumbnail(\'' . $ajax_nonce . '\');return false;">' . esc_html( $post_type_object->labels->remove_featured_image ) . '</a></p>';
         }
-        $content_width = $old_content_width;
     }