Changeset 35030

Timestamp:

10/12/2015 03:03:43 PM (9 years ago)

Author:

boonebgorges

Message:

Fix incorrect setup in 'tag' query var test.

The test, introduced in [33724], was intended to demonstrate the behavior of
example.com?tag=foo routing. But an error in the test setup meant that a
URL-encoded tag object was being set as the value of 'tag'. Due to a quirk in
the way that parse_request() parses query vars, an object value for 'tag'
would inadvertently produce correct results in certain cases. But it's not a
usage we actively support, and it's not what was meant to be tested.

See #33532, #34262.

File:

• trunk/tests/phpunit/tests/query.php (modified) (1 diff)

trunk/tests/phpunit/tests/query.php

@@ -252 +252 @@
 
         $url = add_query_arg( array(
-            'tag' => $t1,
+            'tag' => $t1->slug,
         ), '/' );