WordPress.org

Make WordPress Core


Ignore:
Timestamp:
10/12/2015 03:12:29 PM (6 years ago)
Author:
boonebgorges
Message:

Don't cache WP_Term objects in wp_get_object_cache().

The data stored in the cache should be raw database query results, not
WP_Term objects (which may be modified by plugins, and may contain additional
properties that shouldn't be cached).

If term relationships caches were handled in wp_get_object_terms() - where
a database query takes place - it would be straightforward to cache raw data.
See #34239. Since, in fact, get_the_terms() caches the value it gets from
wp_get_object_terms(), we need a technique that allows us to get raw data
from a WP_Term object. Mirroring WP_User, we introduce a data property
on term objects, which get_the_terms() uses to fetch cacheable term info.

Fixes #34262.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/term.php

    r34646 r35032  
    539539
    540540    /**
     541     * @ticket 34262
     542     */
     543    public function test_get_the_terms_should_not_cache_wp_term_objects() {
     544        $p = $this->factory->post->create();
     545        register_taxonomy( 'wptests_tax', 'post' );
     546        $t = $this->factory->term->create( array( 'taxonomy' => 'wptests_tax' ) );
     547        wp_set_object_terms( $p, $t, 'wptests_tax' );
     548
     549        // Prime the cache.
     550        $terms = get_the_terms( $p, 'wptests_tax' );
     551
     552        $cached = get_object_term_cache( $p, 'wptests_tax' );
     553
     554        $this->assertNotEmpty( $cached );
     555        $this->assertSame( $t, (int) $cached[0]->term_id );
     556        $this->assertNotInstanceOf( 'WP_Term', $cached[0] );
     557    }
     558
     559    /**
     560     * @ticket 34262
     561     */
     562    public function test_get_the_terms_should_return_wp_term_objects_from_cache() {
     563        $p = $this->factory->post->create();
     564        register_taxonomy( 'wptests_tax', 'post' );
     565        $t = $this->factory->term->create( array( 'taxonomy' => 'wptests_tax' ) );
     566        wp_set_object_terms( $p, $t, 'wptests_tax' );
     567
     568        // Prime the cache.
     569        get_the_terms( $p, 'wptests_tax' );
     570
     571        $cached = get_the_terms( $p, 'wptests_tax' );
     572
     573        $this->assertNotEmpty( $cached );
     574        $this->assertSame( $t, (int) $cached[0]->term_id );
     575        $this->assertInstanceOf( 'WP_Term', $cached[0] );
     576    }
     577
     578    /**
    541579     * @ticket 31086
    542580     */
Note: See TracChangeset for help on using the changeset viewer.