Changeset 35032 for trunk/tests/phpunit/tests/term.php

Timestamp:

10/12/2015 03:12:29 PM (9 years ago)

Author:

boonebgorges

Message:

Don't cache WP_Term objects in wp_get_object_cache().

The data stored in the cache should be raw database query results, not
WP_Term objects (which may be modified by plugins, and may contain additional
properties that shouldn't be cached).

If term relationships caches were handled in wp_get_object_terms() - where
a database query takes place - it would be straightforward to cache raw data.
See #34239. Since, in fact, get_the_terms() caches the value it gets from
wp_get_object_terms(), we need a technique that allows us to get raw data
from a WP_Term object. Mirroring WP_User, we introduce a data property
on term objects, which get_the_terms() uses to fetch cacheable term info.

Fixes #34262.

File:

• trunk/tests/phpunit/tests/term.php (modified) (1 diff)

trunk/tests/phpunit/tests/term.php

@@ -539 +539 @@
 
     /**
+     * @ticket 34262
+     */
+    public function test_get_the_terms_should_not_cache_wp_term_objects() {
+        $p = $this->factory->post->create();
+        register_taxonomy( 'wptests_tax', 'post' );
+        $t = $this->factory->term->create( array( 'taxonomy' => 'wptests_tax' ) );
+        wp_set_object_terms( $p, $t, 'wptests_tax' );
+
+        // Prime the cache.
+        $terms = get_the_terms( $p, 'wptests_tax' );
+
+        $cached = get_object_term_cache( $p, 'wptests_tax' );
+
+        $this->assertNotEmpty( $cached );
+        $this->assertSame( $t, (int) $cached[0]->term_id );
+        $this->assertNotInstanceOf( 'WP_Term', $cached[0] );
+    }
+
+    /**
+     * @ticket 34262
+     */
+    public function test_get_the_terms_should_return_wp_term_objects_from_cache() {
+        $p = $this->factory->post->create();
+        register_taxonomy( 'wptests_tax', 'post' );
+        $t = $this->factory->term->create( array( 'taxonomy' => 'wptests_tax' ) );
+        wp_set_object_terms( $p, $t, 'wptests_tax' );
+
+        // Prime the cache.
+        get_the_terms( $p, 'wptests_tax' );
+
+        $cached = get_the_terms( $p, 'wptests_tax' );
+
+        $this->assertNotEmpty( $cached );
+        $this->assertSame( $t, (int) $cached[0]->term_id );
+        $this->assertInstanceOf( 'WP_Term', $cached[0] );
+    }
+
+    /**
      * @ticket 31086
      */