Changeset 35101

Timestamp:

10/13/2015 01:31:53 AM (9 years ago)

Author:

boonebgorges

Message:

Don't match partial roles in WP_User_Query.

Because 'role=ocean90' shouldn't match 'role=bocean901'.

Props bocean901, ocean90.
Fixes #22212.

Location:

trunk

Files:

• src/wp-includes/class-wp-user-query.php (modified) (3 diffs)
• tests/phpunit/tests/user/query.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-user-query.php

@@ -305 +305 @@
                     $roles_clauses[] = array(
                         'key'     => $wpdb->get_blog_prefix( $blog_id ) . 'capabilities',
-                        'value'   => $role,
+                        'value'   => '"' . $role . '"',
                         'compare' => 'LIKE',
                     );
@@ -318 +318 @@
                     $role__in_clauses[] = array(
                         'key'     => $wpdb->get_blog_prefix( $blog_id ) . 'capabilities',
-                        'value'   => $role,
+                        'value'   => '"' . $role . '"',
                         'compare' => 'LIKE',
                     );
@@ -331 +331 @@
                     $role__not_in_clauses[] = array(
                         'key'     => $wpdb->get_blog_prefix( $blog_id ) . 'capabilities',
-                        'value'   => $role,
+                        'value'   => '"' . $role . '"',
                         'compare' => 'NOT LIKE',
                     );

trunk/tests/phpunit/tests/user/query.php

@@ -959 +959 @@
      * @ticket 22212
      */
+    public function test_get_single_role_by_string_which_is_similar() {
+        $editors = $this->factory->user->create_many( 2, array(
+            'role' => 'editor',
+        ) );
+
+        $another_editor = $this->factory->user->create( array(
+            'role' => 'another-editor',
+        ) );
+
+        $users = get_users( array(
+            'role' => 'editor',
+            'fields' => 'ids',
+        ) );
+
+        $this->assertEqualSets( $editors, $users );
+    }
+
+
+    /**
+     * @ticket 22212
+     */
     public function test_get_single_role_by_array() {
         $this->factory->user->create_many( 2, array(