Changeset 35123

Timestamp:

10/13/2015 03:25:42 AM (11 years ago)

Author:

boonebgorges

Message:

Correct expected counts in WP_User_Query 'number' test.

The create_many() number should be padded by just one, to account for the
user created by the test suite. Introduced in [35114].

We also don't have to create so many fixtures to run this test.

See #28631.

File:

• trunk/tests/phpunit/tests/user/query.php (modified) (1 diff)

trunk/tests/phpunit/tests/user/query.php

@@ -439 +439 @@
          */
         function test_number() {
-                $user_ids = $this->factory->user->create_many( 10 );
+                // +1 for the default user created by the test suite.
+                $user_ids = $this->factory->user->create_many( 3 );
 
                 $users = new WP_User_Query( array( 'blog_id' => get_current_blog_id() ) );
                 $users = $users->get_results();
-
-                $this->assertEquals( 12, count( $users ) );
+                $this->assertEquals( 4, count( $users ) );
 
                 $users = new WP_User_Query( array( 'blog_id' => get_current_blog_id(), 'number' => 10 ) );
                 $users = $users->get_results();
-                $this->assertEquals( 10, count( $users ) );
+                $this->assertEquals( 4, count( $users ) );
+
+                $users = new WP_User_Query( array( 'blog_id' => get_current_blog_id(), 'number' => 2 ) );
+                $users = $users->get_results();
+                $this->assertEquals( 2, count( $users ) );
 
                 $users = new WP_User_Query( array( 'blog_id' => get_current_blog_id(), 'number' => -1 ) );
                 $users = $users->get_results();
-                $this->assertEquals( 12, count( $users ) );
+                $this->assertEquals( 4, count( $users ) );
         }