Changeset 35181

Timestamp:

10/15/2015 02:54:20 AM (11 years ago)

Author:

wonderboymusic

Message:

Unit Tests: in Tests_Media::test_wp_get_attachment_image_srcset_array_no_width(), just toggle metadata, instead of creating a new attachment. Shaves 75ms off the test.

See #30017, #33968.

File:

• trunk/tests/phpunit/tests/media.php (modified) (3 diffs)

trunk/tests/phpunit/tests/media.php

@@ -762 +762 @@
          * @ticket 33641
          */
-        function test_wp_get_attachment_image_srcset_array_no_date_upoads() {
+        function test_wp_get_attachment_image_srcset_array_no_date_uploads() {
                 // Save the current setting for uploads folders
                 $uploads_use_yearmonth_folders = get_option( 'uploads_use_yearmonth_folders' );
@@ -849 +849 @@
                 add_filter( 'wp_generate_attachment_metadata', array( $this, '_test_wp_get_attachment_image_srcset_array_no_width_filter' ) );
 
-                // Make our attachment.
-                $filename = DIR_TESTDATA . '/images/test-image-large.png';
-                $id = $this->factory->attachment->create_upload_object( $filename );
-                $srcset = wp_get_attachment_image_srcset_array( $id, 'medium' );
-
-                // Remove filter.
-                remove_filter( 'wp_generate_attachment_metadata', array( $this, '_test_wp_get_attachment_image_srcset_array_no_width_filter' ) );
+                $old_meta = get_post_meta( self::$large_id, '_wp_attachment_metadata', true );
+                $file = get_attached_file( self::$large_id );
+
+                $data = wp_generate_attachment_metadata( self::$large_id, $file );
+                wp_update_attachment_metadata( self::$large_id, $data );
+
+                $srcset = wp_get_attachment_image_srcset_array( self::$large_id, 'medium' );
+
+                update_post_meta( self::$large_id, '_wp_attachment_metadata', $old_meta );
 
                 // The srcset should be false.
@@ -865 +867 @@
          */
         public function _test_wp_get_attachment_image_srcset_array_no_width_filter( $meta ) {
+                remove_filter( 'wp_generate_attachment_metadata', array( $this, __FUNCTION__ ) );
+
                 $meta['sizes']['medium']['width'] = 0;
                 $meta['sizes']['medium']['height'] = 0;