Changeset 35186 for trunk/tests/phpunit/tests/auth.php

Timestamp:

10/15/2015 04:43:37 AM (11 years ago)

Author:

wonderboymusic

Message:

Unit Tests: implement setUpBeforeClass() and tearDownAfterClass() on WP_UnitTestCase. Use late static binding (plus a gross fallback for PHP 5.2) to check if wpSetUpBeforeClass() or wpTearDownAfterClass() exist on the called class, and then call it and pass a static WP_UnitTest_Factory instance via Dependency Injection, if it exists.

This makes it way easier to add fixtures, and tear them down, without needing to instantiate WP_UnitTest_Factory in every class - removes the need to call commit_transaction() in each individual class.

See #30017, #33968.

File:

• trunk/tests/phpunit/tests/auth.php (modified) (3 diffs)

trunk/tests/phpunit/tests/auth.php

@@ -16 +16 @@
         protected $nonce_failure_hook = 'wp_verify_nonce_failed';
 
-        static function setUpBeforeClass() {
-                parent::setUpBeforeClass();
-
-                $factory = new WP_UnitTest_Factory();
-
+        public static function wpSetUpBeforeClass( $factory ) {
                 self::$_user = $factory->user->create_and_get( array(
                         'user_login' => 'password-tests'
@@ -29 +25 @@
                 require_once( ABSPATH . WPINC . '/class-phpass.php' );
                 self::$wp_hasher = new PasswordHash( 8, true );
-
-                self::commit_transaction();
-        }
-
-        public static function tearDownAfterClass() {
-                parent::tearDownAfterClass();
-
+        }
+
+        public static function wpTearDownAfterClass() {
                 if ( is_multisite() ) {
                         wpmu_delete_user( self::$user_id );
@@ -41 +33 @@
                         wp_delete_user( self::$user_id );
                 }
-
-                self::commit_transaction();
         }