Changeset 35186 for trunk/tests/phpunit/tests/feed/rss2.php

Timestamp:

10/15/2015 04:43:37 AM (9 years ago)

Author:

wonderboymusic

Message:

Unit Tests: implement setUpBeforeClass() and tearDownAfterClass() on WP_UnitTestCase. Use late static binding (plus a gross fallback for PHP 5.2) to check if wpSetUpBeforeClass() or wpTearDownAfterClass() exist on the called class, and then call it and pass a static WP_UnitTest_Factory instance via Dependency Injection, if it exists.

This makes it way easier to add fixtures, and tear them down, without needing to instantiate WP_UnitTest_Factory in every class - removes the need to call commit_transaction() in each individual class.

See #30017, #33968.

File:

• trunk/tests/phpunit/tests/feed/rss2.php (modified) (2 diffs)

trunk/tests/phpunit/tests/feed/rss2.php

@@ -13 +13 @@
     static $posts;
 
-    public static function setUpBeforeClass() {
-        $factory = new WP_UnitTest_Factory();
-
+    public static function wpSetUpBeforeClass( $factory ) {
         self::$user = $factory->user->create();
         self::$posts = $factory->post->create_many( 5, array(
             'post_author' => self::$user,
         ) );
-
-        self::commit_transaction();
     }
 
-    public static function tearDownAfterClass() {
+    public static function wpTearDownAfterClass() {
         if ( is_multisite() ) {
             wpmu_delete_user( self::$user );
@@ -34 +30 @@
             wp_delete_post( $post, true );
         }
-
-        self::commit_transaction();
     }