Changeset 35186 for trunk/tests/phpunit/tests/media.php

Timestamp:

10/15/2015 04:43:37 AM (9 years ago)

Author:

wonderboymusic

Message:

Unit Tests: implement setUpBeforeClass() and tearDownAfterClass() on WP_UnitTestCase. Use late static binding (plus a gross fallback for PHP 5.2) to check if wpSetUpBeforeClass() or wpTearDownAfterClass() exist on the called class, and then call it and pass a static WP_UnitTest_Factory instance via Dependency Injection, if it exists.

This makes it way easier to add fixtures, and tear them down, without needing to instantiate WP_UnitTest_Factory in every class - removes the need to call commit_transaction() in each individual class.

See #30017, #33968.

File:

• trunk/tests/phpunit/tests/media.php (modified) (1 diff)

trunk/tests/phpunit/tests/media.php

@@ -8 +8 @@
     protected static $large_id;
 
-    public static function setUpBeforeClass() {
-        parent::setUpBeforeClass();
-
-        $factory = new WP_UnitTest_Factory();
-
+    public static function wpSetUpBeforeClass( $factory ) {
         $filename = DIR_TESTDATA . '/images/test-image-large.png';
         self::$large_id = $factory->attachment->create_upload_object( $filename );
-
-        self::commit_transaction();
-    }
-
-    public static function tearDownAfterClass() {
-        parent::tearDownAfterClass();
-
+    }
+
+    public static function wpTearDownAfterClass() {
         wp_delete_attachment( self::$large_id );
-
-        self::commit_transaction();
     }