Changeset 35186 for trunk/tests/phpunit/tests/post.php

Timestamp:

10/15/2015 04:43:37 AM (9 years ago)

Author:

wonderboymusic

Message:

Unit Tests: implement setUpBeforeClass() and tearDownAfterClass() on WP_UnitTestCase. Use late static binding (plus a gross fallback for PHP 5.2) to check if wpSetUpBeforeClass() or wpTearDownAfterClass() exist on the called class, and then call it and pass a static WP_UnitTest_Factory instance via Dependency Injection, if it exists.

This makes it way easier to add fixtures, and tear them down, without needing to instantiate WP_UnitTest_Factory in every class - removes the need to call commit_transaction() in each individual class.

See #30017, #33968.

File:

• trunk/tests/phpunit/tests/post.php (modified) (3 diffs)

trunk/tests/phpunit/tests/post.php

@@ -10 +10 @@
     protected static $grammarian_id;
 
-    public static function setUpBeforeClass() {
-        parent::setUpBeforeClass();
-
-        $factory = new WP_UnitTest_Factory();
-
+    public static function wpSetUpBeforeClass( $factory ) {
         self::$editor_id = $factory->user->create( array( 'role' => 'editor' ) );
 
@@ -25 +21 @@
 
         self::$grammarian_id = $factory->user->create( array( 'role' => 'grammarian' ) );
-
-        self::commit_transaction();
-    }
-
-    public static function tearDownAfterClass() {
-        parent::tearDownAfterClass();
-
+    }
+
+    public static function wpTearDownAfterClass() {
         $ids = array( self::$editor_id, self::$grammarian_id );
         foreach ( $ids as $id ) {
@@ -40 +32 @@
             }
         }
-
-        self::commit_transaction();
     }