Changeset 35186 for trunk/tests/phpunit/tests/query/date.php

Timestamp:

10/15/2015 04:43:37 AM (9 years ago)

Author:

wonderboymusic

Message:

Unit Tests: implement setUpBeforeClass() and tearDownAfterClass() on WP_UnitTestCase. Use late static binding (plus a gross fallback for PHP 5.2) to check if wpSetUpBeforeClass() or wpTearDownAfterClass() exist on the called class, and then call it and pass a static WP_UnitTest_Factory instance via Dependency Injection, if it exists.

This makes it way easier to add fixtures, and tear them down, without needing to instantiate WP_UnitTest_Factory in every class - removes the need to call commit_transaction() in each individual class.

See #30017, #33968.

File:

• trunk/tests/phpunit/tests/query/date.php (modified) (2 diffs)

trunk/tests/phpunit/tests/query/date.php

@@ -13 +13 @@
     static $post_ids = array();
 
-    public static function setUpBeforeClass() {
+    public static function wpSetUpBeforeClass( $factory ) {
         // Be careful modifying this. Tests are coded to expect this exact sample data.
         $post_dates = array(
@@ -41 +41 @@
         );
 
-        $factory = new WP_UnitTest_Factory;
-
         foreach ( $post_dates as $post_date ) {
             self::$post_ids[] = $factory->post->create( array( 'post_date' => $post_date ) );
         }
-
-        self::commit_transaction();
-    }
-
-    public static function tearDownAfterClass() {
+    }
+
+    public static function wpTearDownAfterClass() {
         foreach ( self::$post_ids as $post_id ) {
             wp_delete_post( $post_id, true );
         }
-
-        self::commit_transaction();
     }